feat(ebe): added multisig signing API to EBE#19
Merged
Merged
Conversation
alextse-bg
force-pushed
the
WP-4519
branch
2 times, most recently
from
eab7e82 to
8aaee59
Compare
pranavjain97
requested changes
Jun 9, 2025
Comment on lines
+12
to
+20
| if (!source || !pub) { | ||
| throw new Error('Source and public key are required for signing'); | ||
| } |
Contributor
There was a problem hiding this comment.
well txPrebuild is also required. But ideally we'll move all this validation to api-ts after mohammad's changes
Contributor
Author
There was a problem hiding this comment.
added a check for prebuild
| ['bitgo', 'source', 'pub'].forEach((key) => delete req.body[key]); | ||
|
|
||
| // Sign the transaction using BitGo SDK | ||
| const coin = bitgo.coin(req.params.coin); |
Contributor
There was a problem hiding this comment.
you need to verify the transaction
Contributor
Author
There was a problem hiding this comment.
added a verification for prebuild
| // Sign the transaction using BitGo SDK | ||
| const coin = bitgo.coin(req.params.coin); | ||
| try { | ||
| return await coin.signTransaction({ ...req.body, prv }); |
Contributor
There was a problem hiding this comment.
lets not blindly pass req.body to signTransaction. parse the prebuild, verify it and then send it
Contributor
Author
There was a problem hiding this comment.
with prebuild being verified we can now pass it in directly
pranavjain97
approved these changes
Jun 10, 2025
Contributor
pranavjain97
left a comment
pranavjain97
left a comment
There was a problem hiding this comment.
Approving this for now to unblock E2E dev testing, but as a follow up-
- Add integration tests
- Use api-ts once enabled for EBE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-4519