-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ebe): added multisig signing API to EBE #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| import * as express from 'express'; | ||
| import { KmsClient } from '../../kms/kmsClient'; | ||
| import { BitGo, RequestTracer, TransactionPrebuild } from 'bitgo'; | ||
| import logger from '../../logger'; | ||
|
|
||
| export async function signMultisigTransaction( | ||
| req: express.Request, | ||
| res: express.Response, | ||
| ): Promise<any> { | ||
| const { | ||
| source, | ||
| pub, | ||
| txPrebuild, | ||
| }: { source: string; pub: string; txPrebuild: TransactionPrebuild } = req.body; | ||
|
|
||
| if (!source || !pub) { | ||
| throw new Error('Source and public key are required for signing'); | ||
| } else if (!txPrebuild || !txPrebuild.wallet) { | ||
| throw new Error('Transaction prebuild is required for signing'); | ||
| } | ||
|
|
||
| const reqId = new RequestTracer(); | ||
| const bitgo: BitGo = req.body.bitgo; | ||
| const baseCoin = bitgo.coin(req.params.coin); | ||
| const kms = new KmsClient(); | ||
|
|
||
| // verify transaction prebuild | ||
| try { | ||
| await baseCoin.verifyTransaction({ | ||
| txParams: { ...txPrebuild.buildParams }, | ||
| txPrebuild, | ||
| wallet: txPrebuild.wallet, | ||
| verification: {}, | ||
| reqId: reqId, | ||
| walletType: 'onchain', | ||
| }); | ||
| } catch (e) { | ||
| const err = e as Error; | ||
| logger.error('transaction prebuild failed local validation:', err.message); | ||
| logger.error('transaction prebuild:', JSON.stringify(txPrebuild, null, 2)); | ||
| logger.error(err); | ||
| } | ||
|
|
||
| // Retrieve the private key from KMS | ||
| let prv: string; | ||
| try { | ||
| const res = await kms.getKey({ pub, source }); | ||
| prv = res.prv; | ||
| } catch (error: any) { | ||
| res.status(error.status || 500).json({ | ||
| message: error.message || 'Failed to retrieve key from KMS', | ||
| }); | ||
| return; | ||
| } | ||
|
|
||
| // Sign the transaction using BitGo SDK | ||
| const coin = bitgo.coin(req.params.coin); | ||
| try { | ||
| return await coin.signTransaction({ txPrebuild, prv }); | ||
| } catch (error) { | ||
| console.log('error while signing wallet transaction ', error); | ||
| throw error; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import * as z from 'zod'; | ||
|
|
||
| export interface GetKeyParams { | ||
| pub: string; | ||
| source: string; | ||
| } | ||
|
|
||
| export interface GetKeyResponse { | ||
| pub: string; | ||
| prv: string; | ||
| source: 'user' | 'backup'; | ||
| type: 'independent' | 'tss'; | ||
| } | ||
|
|
||
| export const GetKeyKmsSchema = z.object({ | ||
| pub: z.string(), | ||
| prv: z.string(), | ||
| source: z.enum(['user', 'backup']), | ||
| type: z.enum(['independent', 'tss']), | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to verify the transaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a verification for prebuild