refactor!: rename KMS to Key Provider across codebase by pranavjain97 · Pull Request #195 · BitGo/advanced-wallets

pranavjain97 · 2026-04-28T19:19:13Z

Summary

Rename all "KMS" references to "Key Provider" across the codebase to accurately reflect the vendor-agnostic nature of the key management interface
The current "KMS" naming causes confusion with AWS KMS and implies clients need a KMS specifically, when the interface works equally well with bare HSMs (e.g., Dinamo)
The Key Provider API contract itself is unchanged -- this is a naming/config change only

gokulhost

Rename

alextse-bg · 2026-04-28T20:08:48Z

@claude do a code scan over the repo and see if all mentions of kms are replaced with key provider (with appropriate casing/styling). You only have to report any thing that is missed by this PR. On top of that, review the changes made in this PR makes grammatical, syntactical and stylistic sense.

vmccarty

The term key provider and advanced wallet key provider are informal nouns, so they should be lower case unless starting a sentence or used in a titile.

BREAKING CHANGE: All KMS-related environment variables have been renamed. Update your deployment configuration (Helm values, docker-compose, .env files, CI pipelines) before upgrading: KMS_URL -> KEY_PROVIDER_URL KMS_SERVER_CA_CERT_PATH -> KEY_PROVIDER_SERVER_CA_CERT_PATH KMS_CLIENT_TLS_KEY_PATH -> KEY_PROVIDER_CLIENT_TLS_KEY_PATH KMS_CLIENT_TLS_CERT_PATH -> KEY_PROVIDER_CLIENT_TLS_CERT_PATH KMS_CLIENT_TLS_KEY -> KEY_PROVIDER_CLIENT_TLS_KEY KMS_CLIENT_TLS_CERT -> KEY_PROVIDER_CLIENT_TLS_CERT KMS_SERVER_CERT_ALLOW_SELF_SIGNED -> KEY_PROVIDER_SERVER_CERT_ALLOW_SELF_SIGNED The KMS API specification file has been renamed from kms-api-spec.yaml to key-provider-api-spec.yaml. The API contract itself is unchanged -- only the naming has been updated to accurately reflect the vendor-agnostic nature of the key management interface.

vmccarty

LGTM

Corrects the version from 2.1.1 to 3.0.0. PR #195 (refactor: rename KMS to Key Provider) introduced a breaking change that was not reflected in the semver bump at the time: All KMS_* environment variables were renamed to KEY_PROVIDER_*: KMS_URL -> KEY_PROVIDER_URL KMS_SERVER_CA_CERT_PATH -> KEY_PROVIDER_SERVER_CA_CERT_PATH KMS_CLIENT_TLS_KEY_PATH -> KEY_PROVIDER_CLIENT_TLS_KEY_PATH KMS_CLIENT_TLS_CERT_PATH -> KEY_PROVIDER_CLIENT_TLS_CERT_PATH KMS_CLIENT_TLS_KEY -> KEY_PROVIDER_CLIENT_TLS_KEY KMS_CLIENT_TLS_CERT -> KEY_PROVIDER_CLIENT_TLS_CERT KMS_CLIENT_TLS_CA_CERT -> KEY_PROVIDER_CLIENT_TLS_CA_CERT KMS_SERVER_CERT_ALLOW_SELF_SIGNED -> KEY_PROVIDER_SERVER_CERT_ALLOW_SELF_SIGNED Any deployment using the old KMS_* env vars will break without a config update. Per semver, a breaking change to the public configuration interface requires a major version bump. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Corrects the version from 2.1.1 to 3.0.0. PR #195 (refactor: rename KMS to Key Provider) introduced a breaking change that was not reflected in the semver bump at the time: All KMS_* environment variables were renamed to KEY_PROVIDER_*: KMS_URL -> KEY_PROVIDER_URL KMS_SERVER_CA_CERT_PATH -> KEY_PROVIDER_SERVER_CA_CERT_PATH KMS_CLIENT_TLS_KEY_PATH -> KEY_PROVIDER_CLIENT_TLS_KEY_PATH KMS_CLIENT_TLS_CERT_PATH -> KEY_PROVIDER_CLIENT_TLS_CERT_PATH KMS_CLIENT_TLS_KEY -> KEY_PROVIDER_CLIENT_TLS_KEY KMS_CLIENT_TLS_CERT -> KEY_PROVIDER_CLIENT_TLS_CERT KMS_CLIENT_TLS_CA_CERT -> KEY_PROVIDER_CLIENT_TLS_CA_CERT KMS_SERVER_CERT_ALLOW_SELF_SIGNED -> KEY_PROVIDER_SERVER_CERT_ALLOW_SELF_SIGNED Any deployment using the old KMS_* env vars will break without a config update. Per semver, a breaking change to the public configuration interface requires a major version bump. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Ticket: WAL-1481

BREAKING CHANGE: All KMS_* environment variables were renamed to KEY_PROVIDER_* in PR #195. Any deployment using the old variable names will break without a config update: KMS_URL -> KEY_PROVIDER_URL KMS_SERVER_CA_CERT_PATH -> KEY_PROVIDER_SERVER_CA_CERT_PATH KMS_CLIENT_TLS_KEY_PATH -> KEY_PROVIDER_CLIENT_TLS_KEY_PATH KMS_CLIENT_TLS_CERT_PATH -> KEY_PROVIDER_CLIENT_TLS_CERT_PATH KMS_CLIENT_TLS_KEY -> KEY_PROVIDER_CLIENT_TLS_KEY KMS_CLIENT_TLS_CERT -> KEY_PROVIDER_CLIENT_TLS_CERT KMS_CLIENT_TLS_CA_CERT -> KEY_PROVIDER_CLIENT_TLS_CA_CERT KMS_SERVER_CERT_ALLOW_SELF_SIGNED -> KEY_PROVIDER_SERVER_CERT_ALLOW_SELF_SIGNED This was missed in the prior semver bump (2.1.0 -> 2.1.1). Correcting to 3.0.0 per semver convention. Ticket: WAL-1481 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

pranavjain97 requested a review from a team as a code owner April 28, 2026 19:19

pranavjain97 requested review from alextse-bg and mrdanish26 April 28, 2026 19:19

pranavjain97 force-pushed the refactor/rename-kms-to-key-provider branch 2 times, most recently from d155604 to a4df12a Compare April 28, 2026 19:56

gokulhost previously approved these changes Apr 28, 2026

View reviewed changes

alextse-bg reviewed Apr 28, 2026

View reviewed changes

Comment thread demo-key-provider-script/aws-interface.md Outdated

pranavjain97 requested a review from vmccarty April 28, 2026 20:18

pranavjain97 dismissed gokulhost’s stale review via cc72303 April 28, 2026 21:04

pranavjain97 force-pushed the refactor/rename-kms-to-key-provider branch 3 times, most recently from c7e9751 to ba8358b Compare April 28, 2026 21:11

pranavjain97 requested review from alextse-bg and gokulhost April 28, 2026 21:56

alextse-bg previously approved these changes Apr 29, 2026

View reviewed changes