chore: add SigningMode config and refactor KeyProviderClient HTTP layer#198
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Introduces SigningMode enum (local/external) as a first-class config field on AdvancedWalletManagerConfig, wired through initConfig with env var validation. Refactors KeyProviderClient to eliminate repeated HTTP boilerplate via a generic call<M>() helper using conditional types. Ticket: WCN-397
| } catch (error: any) { | ||
| this.errorHandler(error, 'Error posting key to key provider'); | ||
| } | ||
| const response = await this.call('post', `${this.url}/key`, { |
Contributor
There was a problem hiding this comment.
what's the reason for these call changes?
Contributor
Author
There was a problem hiding this comment.
Duplicate code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Introduces SigningMode enum (local/external) as a first-class config field on AdvancedWalletManagerConfig, wired through initConfig with env var validation. Refactors KeyProviderClient to eliminate repeated HTTP boilerplate via a generic call() helper using conditional types.
Ticket: WCN-397
Testing