refactor: enhance recovery-related tests with API mocks#221
Merged
Conversation
pranishnepal
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth (and final
/mastertests) pass. This is for de- mocking the recovery tests to use real SDK functions.Updated
musigRecovery.test.ts,nonRecovery.test.ts,recoveryWallet.test.ts,recoveryConsolidationsWallet.test.ts,recoveryWalletMpcV2.test.tssendMany, recovery endpoints take keys in the request body and don’t fetch wallets from BitGo, so the realexpressApp(config)app setup works as-is without that stubbing now. We nock external chain APIs (Blockchair, Etherscan, TronGrid, Solana/SUI RPC) instead of stubbingcoin.recover/recoverConsolidations.beforeEach->beforesince app setup no longer depends on sinon stubs, so we create the app once and reset nocks/stubs inafterEach.recoveryConsolidationsWallet.test.tscome verbatim from the SDK’s test fixtures so derivation and tx building match what the real SDK expects. AWM signing is still nocked.Trx.prototype.recoverConsolidationsin the “unexpected result structure” test as it's the only way to hit that error path since the real SDK always returns{ transactions }or{ txRequests }.Ticket: WAL-1489