Skip to content

feat: implement client to abstract bridge calls #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pranishnepal merged 1 commit into from
Jun 10, 2026
Merged

feat: implement client to abstract bridge calls #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 14 additions & 27 deletions src/__tests__/api/advancedWalletManager/keyProviderClient.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ describe('postMpcV2Key', () => {

response.status.should.equal(500);
response.body.should.have.property('error', 'Internal Server Error');
response.body.should.have.property('details', 'This is an error message');
response.body.details.should.match(/This is an error message/);
});

it('should handle unexpected key provider errors', async () => {
Expand All @@ -106,10 +106,7 @@ describe('postMpcV2Key', () => {

response.status.should.equal(500);
response.body.should.have.property('error', 'Internal Server Error');
response.body.should.have.property(
'details',
'key provider returned unexpected response. 502: Unexpected error',
);
response.body.details.should.match(/502.*Unexpected error/);
});
});

Expand Down Expand Up @@ -150,27 +147,17 @@ describe('KeyProviderClient.generateKey', () => {
});

[
{
url: endPointPath,
statusCode: 400,
mockedError: 'bad request',
expectedError: 'bad request',
},
{ url: endPointPath, statusCode: 404, mockedError: 'not found', expectedError: 'not found' },
{ url: endPointPath, statusCode: 409, mockedError: 'conflict', expectedError: 'conflict' },
{
url: endPointPath,
statusCode: 500,
mockedError: 'internal error',
expectedError: 'internal error',
},
].forEach(({ url, statusCode, mockedError, expectedError }) => {
{ url: endPointPath, statusCode: 400, mockedError: 'bad request' },
{ url: endPointPath, statusCode: 404, mockedError: 'not found' },
{ url: endPointPath, statusCode: 409, mockedError: 'conflict' },
{ url: endPointPath, statusCode: 500, mockedError: 'internal error' },
].forEach(({ url, statusCode, mockedError }) => {
it(`should bubble up ${statusCode} errors`, async () => {
const nockMocked = nock(keyProviderUrl)
.post(url)
.reply(statusCode, { message: mockedError })
.persist();
await client.generateKey(params).should.be.rejectedWith(expectedError);
await client.generateKey(params).should.be.rejectedWith(new RegExp(mockedError));
nockMocked.done();
});
});
Expand Down Expand Up @@ -222,17 +209,17 @@ describe('KeyProviderClient.sign', () => {
});

[
{ statusCode: 400, mockedError: 'bad request', expectedError: 'bad request' },
{ statusCode: 404, mockedError: 'not found', expectedError: 'not found' },
{ statusCode: 409, mockedError: 'conflict', expectedError: 'conflict' },
{ statusCode: 500, mockedError: 'internal error', expectedError: 'internal error' },
].forEach(({ statusCode, mockedError, expectedError }) => {
{ statusCode: 400, mockedError: 'bad request' },
{ statusCode: 404, mockedError: 'not found' },
{ statusCode: 409, mockedError: 'conflict' },
{ statusCode: 500, mockedError: 'internal error' },
].forEach(({ statusCode, mockedError }) => {
it(`should bubble up ${statusCode} errors`, async () => {
const nockMocked = nock(keyProviderUrl)
.post(endPointPath)
.reply(statusCode, { message: mockedError })
.persist();
await client.sign(params).should.be.rejectedWith(expectedError);
await client.sign(params).should.be.rejectedWith(new RegExp(mockedError));
nockMocked.done();
});
});
Expand Down
Loading
Loading