wip(mbe): setup flow for eddsa initialization#33
Closed
mohammadalfaiyazbitgo wants to merge 3 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR lays the groundwork for on-premises MPC (TSS) wallet generation by introducing initialization/finalization endpoints and wiring them into the existing generate-wallet route.
- Adds
handleGenerateOnPremMpcWalletfor TSS wallet flow and updates the router to dispatch bymultisigType. - Implements
initMpcKeyGeneration/finalizeMpcKeyGenerationinEnclavedExpressClientand corresponding API spec routes. - Extends tests to simulate the TSS initialization call and adds a WIP integration log document.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/masterBitgoExpress/generateWallet.ts | Renamed on-chain handler, added handleGenerateOnPremMpcWallet |
| src/masterBitgoExpress/enclavedExpressClient.ts | Added initMpcKeyGeneration and finalizeMpcKeyGeneration |
| src/enclavedBitgoExpress/routers/enclavedApiSpec.ts | Defined /mpc/initialize and /mpc/finalize spec and routes |
| src/tests/masterBitgoExpress/generateWallet.test.ts | Added test for TSS wallet initialization call |
| src/tests/masterBitgoExpress/.wip.md | Work-in-progress notes and example logs |
Comments suppressed due to low confidence (3)
src/tests/masterBitgoExpress/generateWallet.test.ts:15
- [nitpick] The test variable
eddsaCoinis misleading in the context of an MPC/TSS flow; consider renaming it tompcCoinortssCoinfor clarity.
const eddsaCoin = 'tsol';
src/masterBitgoExpress/generateWallet.ts:135
- RequestTracer is referenced but never imported; please add
import { RequestTracer } from '@bitgo/sdk-core';to avoid a ReferenceError.
const reqId = new RequestTracer(); // Create tracer without storing reference since it's not used
src/tests/masterBitgoExpress/.wip.md:1
- [nitpick] This WIP markdown contains extensive implementation notes and example logs that clutter the test suite; consider removing it or relocating to a separate docs directory.
# Notes
| import { prepareBitGo, responseHandler } from '../../shared/middleware'; | ||
| import { EnclavedConfig } from '../../types'; | ||
| import { BitGoRequest } from '../../types/request'; | ||
| import { NotImplementedError } from 'bitgo'; |
There was a problem hiding this comment.
[nitpick] Importing NotImplementedError from 'bitgo' may be inconsistent with other modules using @bitgo/sdk-core; align the import source to avoid mismatches.
Suggested change
| import { NotImplementedError } from 'bitgo'; | |
| import { NotImplementedError } from '@bitgo/sdk-core'; |
Contributor
Author
|
moved to #35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-4758