Skip to content

wip(mbe): setup flow for eddsa initialization#33

Closed
mohammadalfaiyazbitgo wants to merge 3 commits into
masterfrom
WP-4758/mbe-eddsa-keygen
Closed

wip(mbe): setup flow for eddsa initialization#33
mohammadalfaiyazbitgo wants to merge 3 commits into
masterfrom
WP-4758/mbe-eddsa-keygen

Conversation

@mohammadalfaiyazbitgo

Copy link
Copy Markdown
Contributor

Ticket: WP-4758

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR lays the groundwork for on-premises MPC (TSS) wallet generation by introducing initialization/finalization endpoints and wiring them into the existing generate-wallet route.

  • Adds handleGenerateOnPremMpcWallet for TSS wallet flow and updates the router to dispatch by multisigType.
  • Implements initMpcKeyGeneration/finalizeMpcKeyGeneration in EnclavedExpressClient and corresponding API spec routes.
  • Extends tests to simulate the TSS initialization call and adds a WIP integration log document.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/masterBitgoExpress/generateWallet.ts Renamed on-chain handler, added handleGenerateOnPremMpcWallet
src/masterBitgoExpress/enclavedExpressClient.ts Added initMpcKeyGeneration and finalizeMpcKeyGeneration
src/enclavedBitgoExpress/routers/enclavedApiSpec.ts Defined /mpc/initialize and /mpc/finalize spec and routes
src/tests/masterBitgoExpress/generateWallet.test.ts Added test for TSS wallet initialization call
src/tests/masterBitgoExpress/.wip.md Work-in-progress notes and example logs
Comments suppressed due to low confidence (3)

src/tests/masterBitgoExpress/generateWallet.test.ts:15

  • [nitpick] The test variable eddsaCoin is misleading in the context of an MPC/TSS flow; consider renaming it to mpcCoin or tssCoin for clarity.
  const eddsaCoin = 'tsol';

src/masterBitgoExpress/generateWallet.ts:135

  • RequestTracer is referenced but never imported; please add import { RequestTracer } from '@bitgo/sdk-core'; to avoid a ReferenceError.
  const reqId = new RequestTracer(); // Create tracer without storing reference since it's not used

src/tests/masterBitgoExpress/.wip.md:1

  • [nitpick] This WIP markdown contains extensive implementation notes and example logs that clutter the test suite; consider removing it or relocating to a separate docs directory.
# Notes

import { prepareBitGo, responseHandler } from '../../shared/middleware';
import { EnclavedConfig } from '../../types';
import { BitGoRequest } from '../../types/request';
import { NotImplementedError } from 'bitgo';

Copilot AI Jun 19, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Importing NotImplementedError from 'bitgo' may be inconsistent with other modules using @bitgo/sdk-core; align the import source to avoid mismatches.

Suggested change
import { NotImplementedError } from 'bitgo';
import { NotImplementedError } from '@bitgo/sdk-core';

Copilot uses AI. Check for mistakes.
@mohammadalfaiyazbitgo

Copy link
Copy Markdown
Contributor Author

moved to #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants