feat(ebe): added EBE api for mpc v2#49
Closed
alextse-bg wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for MPC v2 key generation workflows by introducing three new endpoints (initialize, round, finalize) in the Enclaved API, along with their handlers, type definitions, integration tests, and a new MPC library dependency.
- Added MPC v2 request/response types and HTTP routes in the API spec
- Implemented
mpcV2Initialize,mpcV2Round, andmpcV2Finalizehandlers - Created end-to-end integration tests for the full MPC v2 flow and updated
package.json
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/enclavedBitgoExpress/routers/enclavedApiSpec.ts | Define MPC v2 types and register new API routes for initialize/round/finalize |
| src/api/enclaved/handlers/mpcV2Initialize.ts | Handler logic for MPC v2 initialization |
| src/api/enclaved/handlers/mpcV2Round.ts | Handler logic for each MPC v2 round |
| src/api/enclaved/handlers/mpcV2Finalize.ts | Handler logic to finalize MPC v2 protocol |
| src/tests/api/enclaved/postMpcV2Key.test.ts | Integration tests covering the entire MPC v2 lifecycle |
| package.json | Added @bitgo/sdk-lib-mpc dependency |
Comments suppressed due to low confidence (1)
src/enclavedBitgoExpress/routers/enclavedApiSpec.ts:172
- The response field is named
broadcastMessage(singular) but tests and other logic expectbroadcastMessages(plural). Rename this field for consistency.
broadcastMessage: optional(t.any),
7ee16e9 to
7c6a22b
Compare
Contributor
Author
|
Duplicate with PR: #54 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.