Skip to content

feat(ebe): added EBE api for mpc v2#49

Closed
alextse-bg wants to merge 1 commit into
masterfrom
WP-5149
Closed

feat(ebe): added EBE api for mpc v2#49
alextse-bg wants to merge 1 commit into
masterfrom
WP-5149

Conversation

@alextse-bg

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for MPC v2 key generation workflows by introducing three new endpoints (initialize, round, finalize) in the Enclaved API, along with their handlers, type definitions, integration tests, and a new MPC library dependency.

  • Added MPC v2 request/response types and HTTP routes in the API spec
  • Implemented mpcV2Initialize, mpcV2Round, and mpcV2Finalize handlers
  • Created end-to-end integration tests for the full MPC v2 flow and updated package.json

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/enclavedBitgoExpress/routers/enclavedApiSpec.ts Define MPC v2 types and register new API routes for initialize/round/finalize
src/api/enclaved/handlers/mpcV2Initialize.ts Handler logic for MPC v2 initialization
src/api/enclaved/handlers/mpcV2Round.ts Handler logic for each MPC v2 round
src/api/enclaved/handlers/mpcV2Finalize.ts Handler logic to finalize MPC v2 protocol
src/tests/api/enclaved/postMpcV2Key.test.ts Integration tests covering the entire MPC v2 lifecycle
package.json Added @bitgo/sdk-lib-mpc dependency
Comments suppressed due to low confidence (1)

src/enclavedBitgoExpress/routers/enclavedApiSpec.ts:172

  • The response field is named broadcastMessage (singular) but tests and other logic expect broadcastMessages (plural). Rename this field for consistency.
  broadcastMessage: optional(t.any),

Comment thread src/enclavedBitgoExpress/routers/enclavedApiSpec.ts Outdated
Comment thread src/api/enclaved/handlers/mpcV2Round.ts Outdated
Comment thread src/api/enclaved/handlers/mpcV2Round.ts Outdated
Comment thread src/api/enclaved/handlers/mpcV2Round.ts Outdated
Comment thread src/api/enclaved/handlers/mpcV2Round.ts Outdated
@alextse-bg alextse-bg force-pushed the WP-5149 branch 3 times, most recently from 7ee16e9 to 7c6a22b Compare June 30, 2025 18:09
@alextse-bg

Copy link
Copy Markdown
Contributor Author

Duplicate with PR: #54

@alextse-bg alextse-bg closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants