ci: enable commit lint for future commits#73
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements commit linting to enforce standardized commit message formats for future commits. The implementation adds commitlint tooling with conventional commit standards and integrates it into the CI pipeline.
- Adds commitlint dependencies and configuration with custom rules for the project
- Creates a new CI job to validate commit messages in pull requests
- Optimizes CI workflow by adding dependency caching across all jobs
- Provides a commit message template to guide developers
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds commitlint dependencies and reorganizes existing dependencies alphabetically |
| git_commit_template.txt | Provides commit message template with BitGo's commit standards |
| .github/workflows/build-and-test.yaml | Adds commit-lint job and dependency caching for all existing jobs |
| .commitlintrc.json | Configures commitlint rules with project-specific scope enums and issue prefixes |
| lint: | ||
| name: Run lint | ||
| runs-on: ubuntu-latest | ||
| needs: [commit-lint] |
There was a problem hiding this comment.
The lint job depends on commit-lint, but commit-lint only runs on pull requests while lint runs on all events. This will cause the lint job to fail when commit-lint is skipped (e.g., on push events). Consider removing this dependency or adding the same condition to the lint job.
Suggested change
| needs: [commit-lint] |
b1b5127 to
05a90cf
Compare
pranavjain97
requested changes
Jul 17, 2025
pranavjain97
left a comment
Contributor
There was a problem hiding this comment.
Nice! remove the package-lock.json lol
05a90cf to
3a83ec4
Compare
pranavjain97
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-5314