Skip to content

ci: enable commit lint for future commits#73

Merged
mohammadalfaiyazbitgo merged 2 commits into
masterfrom
WP-5314/apply-conventional-commit
Jul 18, 2025
Merged

ci: enable commit lint for future commits#73
mohammadalfaiyazbitgo merged 2 commits into
masterfrom
WP-5314/apply-conventional-commit

Conversation

@mohammadalfaiyazbitgo

Copy link
Copy Markdown
Contributor

Ticket: WP-5314

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo marked this pull request as ready for review July 17, 2025 21:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements commit linting to enforce standardized commit message formats for future commits. The implementation adds commitlint tooling with conventional commit standards and integrates it into the CI pipeline.

  • Adds commitlint dependencies and configuration with custom rules for the project
  • Creates a new CI job to validate commit messages in pull requests
  • Optimizes CI workflow by adding dependency caching across all jobs
  • Provides a commit message template to guide developers

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

File Description
package.json Adds commitlint dependencies and reorganizes existing dependencies alphabetically
git_commit_template.txt Provides commit message template with BitGo's commit standards
.github/workflows/build-and-test.yaml Adds commit-lint job and dependency caching for all existing jobs
.commitlintrc.json Configures commitlint rules with project-specific scope enums and issue prefixes

Comment thread .github/workflows/build-and-test.yaml Outdated
lint:
name: Run lint
runs-on: ubuntu-latest
needs: [commit-lint]

Copilot AI Jul 17, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lint job depends on commit-lint, but commit-lint only runs on pull requests while lint runs on all events. This will cause the lint job to fail when commit-lint is skipped (e.g., on push events). Consider removing this dependency or adding the same condition to the lint job.

Suggested change
needs: [commit-lint]

Copilot uses AI. Check for mistakes.
@mohammadalfaiyazbitgo mohammadalfaiyazbitgo force-pushed the WP-5314/apply-conventional-commit branch from b1b5127 to 05a90cf Compare July 17, 2025 21:55

@pranavjain97 pranavjain97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! remove the package-lock.json lol

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo force-pushed the WP-5314/apply-conventional-commit branch from 05a90cf to 3a83ec4 Compare July 18, 2025 18:46
@mohammadalfaiyazbitgo mohammadalfaiyazbitgo merged commit eb2c974 into master Jul 18, 2025
4 checks passed
@mohammadalfaiyazbitgo mohammadalfaiyazbitgo deleted the WP-5314/apply-conventional-commit branch July 18, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants