Skip to content

chore(mbe): clean up / consolidate configs for mbe/ebe #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pranavjain97 merged 5 commits into from
Jul 24, 2025
Merged

chore(mbe): clean up / consolidate configs for mbe/ebe #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9742332
test(mbe): add more config tests for master express
pranavjain97 Jul 22, 2025
18848f8
chore(mbe): remove mtlsRequestCert from config
pranavjain97 Jul 24, 2025
1567585
chore(mbe): remove DEBUG_NAMESPACE config
pranavjain97 Jul 24, 2025
29dfdbb
chore(mbe): rename logFile to httpLogger
pranavjain97 Jul 24, 2025
54e5298
chore(mbe): add default file for http access logs
pranavjain97 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@ Both modes use the same TLS configuration variables:

### Logging and Debug

- `LOGFILE` - Path to log file (optional)
- `DEBUG_NAMESPACE` - Debug namespaces to enable (e.g., 'enclaved:\*')
- `HTTP_LOGFILE` - Path to HTTP request log file (optional, used by Morgan for HTTP access logs)

## Quick Start

Expand Down Expand Up @@ -232,6 +231,7 @@ curl -k -X POST https://localhost:3081/ping/enclavedExpress
```

Notes:

- `host.containers.internal` is a special DNS name that resolves to the host machine from inside containers
- The `:Z` option in volume mounts is specific to SELinux-enabled systems and ensures proper volume labeling
- The logs directory will be created with appropriate permissions if it doesn't exist
Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/enclaved/postIndependentKey.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,9 @@ describe('postIndependentKey', () => {
port: 0, // Let OS assign a free port
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
kmsUrl: kmsUrl,
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/enclaved/postMpcV2Key.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,9 @@ describe('postMpcV2Key', () => {
port: 0, // Let OS assign a free port
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
kmsUrl: kmsUrl,
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/enclaved/recoveryMultisigTransaction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ describe('UTXO recovery', () => {
port: 0,
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
kmsUrl: 'kms.example.com',
};
Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/enclaved/recoveryMusigEth.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,9 @@ describe('recoveryMultisigTransaction', () => {
port: 0, // Let OS assign a free port
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
kmsUrl: kmsUrl,
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
5 changes: 2 additions & 3 deletions src/__tests__/api/enclaved/signMpcRecoveryTransaction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,14 @@ import { AppMode, EnclavedConfig, TlsMode } from '../../../shared/types';
describe('EdDSA Recovery Signing', () => {
let agent: supertest.SuperTest<supertest.Test>;
const config: EnclavedConfig = {
kmsUrl: 'http://localhost:3000',
appMode: AppMode.ENCLAVED,
port: 0,
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
kmsUrl: 'kms.example.com',
};

const commonKeychain =
Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/enclaved/signMpcTransaction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,9 @@ describe('signMpcTransaction', () => {
port: 0, // Let OS assign a free port
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
kmsUrl: kmsUrl,
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/enclaved/signMultisigTransaction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,9 @@ describe('signMultisigTransaction', () => {
port: 0, // Let OS assign a free port
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
kmsUrl: kmsUrl,
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/master/accelerate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,13 @@ describe('POST /api/:coin/wallet/:walletId/accelerate', () => {
port: 0, // Let OS assign a free port
bind: 'localhost',
timeout: 30000,
logFile: '',
httpLoggerFile: '',
env: 'test',
disableEnvCheck: true,
authVersion: 2,
enclavedExpressUrl: enclavedExpressUrl,
enclavedExpressCert: 'test-cert',
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/master/consolidate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,13 @@ describe('POST /api/:coin/wallet/:walletId/consolidateunspents', () => {
port: 0,
bind: 'localhost',
timeout: 30000,
logFile: '',
httpLoggerFile: '',
env: 'test',
disableEnvCheck: true,
authVersion: 2,
enclavedExpressUrl: enclavedExpressUrl,
enclavedExpressCert: 'test-cert',
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/master/consolidateUnspents.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,13 @@ describe('POST /api/:coin/wallet/:walletId/consolidateunspents', () => {
port: 0,
bind: 'localhost',
timeout: 30000,
logFile: '',
httpLoggerFile: '',
env: 'test',
disableEnvCheck: true,
authVersion: 2,
enclavedExpressUrl: enclavedExpressUrl,
enclavedExpressCert: 'test-cert',
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
6 changes: 2 additions & 4 deletions src/__tests__/api/master/generateWallet.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,13 @@ describe('POST /api/:coin/wallet/generate', () => {
port: 0, // Let OS assign a free port
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
env: 'test',
disableEnvCheck: true,
authVersion: 2,
enclavedExpressUrl: enclavedExpressUrl,
enclavedExpressCert: 'dummy-cert',
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down Expand Up @@ -1122,12 +1121,11 @@ describe('POST /api/:coin/wallet/generate', () => {
port: 0,
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
env: 'test',
disableEnvCheck: true,
authVersion: 2,
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/master/musigRecovery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,13 @@ describe('POST /api/:coin/wallet/recovery', () => {
port: 0, // Let OS assign a free port
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
env: 'test',
disableEnvCheck: true,
authVersion: 2,
enclavedExpressUrl: enclavedExpressUrl,
enclavedExpressCert: 'dummy-cert',
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/master/recoveryConsolidationsWallet.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,13 @@ describe('POST /api/:coin/wallet/recoveryconsolidations', () => {
port: 0,
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
env: 'test',
disableEnvCheck: true,
authVersion: 2,
enclavedExpressUrl,
enclavedExpressCert: 'dummy-cert',
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};
const app = expressApp(config);
Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/master/recoveryWallet.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,13 @@ describe('Recovery Tests', () => {
port: 0,
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
env: 'test',
disableEnvCheck: true,
authVersion: 2,
enclavedExpressUrl: enclavedExpressUrl,
enclavedExpressCert: 'dummy-cert',
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
6 changes: 2 additions & 4 deletions src/__tests__/api/master/sendMany.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,13 @@ describe('POST /api/:coin/wallet/:walletId/sendmany', () => {
port: 0, // Let OS assign a free port
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
env: 'test',
disableEnvCheck: true,
authVersion: 2,
enclavedExpressUrl: enclavedExpressUrl,
enclavedExpressCert: 'dummy-cert',
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down Expand Up @@ -580,12 +579,11 @@ describe('POST /api/:coin/wallet/:walletId/sendmany', () => {
port: 0,
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
env: 'test',
disableEnvCheck: true,
authVersion: 2,
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
3 changes: 1 addition & 2 deletions src/__tests__/api/master/signAndSendTxRequest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,13 @@ describe('POST /api/:coin/wallet/:walletId/txrequest/:txRequestId/signAndSend',
port: 0, // Let OS assign a free port
bind: 'localhost',
timeout: 60000,
logFile: '',
httpLoggerFile: '',
env: 'test',
disableEnvCheck: true,
authVersion: 2,
enclavedExpressUrl: enclavedExpressUrl,
enclavedExpressCert: 'dummy-cert',
tlsMode: TlsMode.DISABLED,
mtlsRequestCert: false,
allowSelfSigned: true,
};

Expand Down
Empty file added src/__tests__/api/secured/postIndependentKey.test.ts
View file
Open in desktop
Empty file.
Loading