From 21c1c713b056c8c46621866766842eee775bae86 Mon Sep 17 00:00:00 2001 From: Pranav Jain Date: Thu, 24 Jul 2025 13:30:52 -0400 Subject: [PATCH] chore(mbe): hide winston/http logs in test runs Ticket: WP-5365 --- package.json | 2 +- src/logger.ts | 1 + src/shared/appUtils.ts | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 1d8dca6..6386b0c 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ "scripts": { "start": "nodemon", "build": "yarn tsc --build --incremental --verbose . && cp package.json dist/", - "test": "mocha --require ts-node/register 'src/**/__tests__/**/*.test.ts'", + "test": "NODE_ENV=test mocha --require ts-node/register 'src/**/__tests__/**/*.test.ts'", "test:watch": "mocha --require ts-node/register --watch 'src/**/__tests__/**/*.test.ts'", "test:coverage": "nyc mocha --require ts-node/register 'src/**/__tests__/**/*.test.ts'", "lint": "eslint --quiet --ignore-pattern scripts/bump-version.ts .", diff --git a/src/logger.ts b/src/logger.ts index 71b2be1..384259a 100644 --- a/src/logger.ts +++ b/src/logger.ts @@ -11,6 +11,7 @@ const levels = { // Define level based on environment const level = () => { + if (process.env.NODE_ENV === 'test' || process.env.LOG_LEVEL === 'silent') return 'silent'; const env = process.env.NODE_ENV || 'development'; const isDevelopment = env === 'development'; return isDevelopment ? 'debug' : 'warn'; diff --git a/src/shared/appUtils.ts b/src/shared/appUtils.ts index 1af51e6..befa51e 100644 --- a/src/shared/appUtils.ts +++ b/src/shared/appUtils.ts @@ -16,6 +16,9 @@ import { Config, TlsMode } from '../shared/types'; */ export function setupLogging(app: express.Application, config: Config): void { // Set up morgan for logging, with optional logging into a file + if (process.env.NODE_ENV === 'test' || process.env.LOG_LEVEL === 'silent') { + return; + } let middleware; if (config.logFile) { // create a write stream (in append mode)