Skip to content

chore(mbe): hide winston/http logs in test runs #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pranavjain97 merged 1 commit into from
Jul 24, 2025
Merged

chore(mbe): hide winston/http logs in test runs #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"scripts": {
"start": "nodemon",
"build": "yarn tsc --build --incremental --verbose . && cp package.json dist/",
"test": "mocha --require ts-node/register 'src/**/__tests__/**/*.test.ts'",
"test": "NODE_ENV=test mocha --require ts-node/register 'src/**/__tests__/**/*.test.ts'",
"test:watch": "mocha --require ts-node/register --watch 'src/**/__tests__/**/*.test.ts'",
"test:coverage": "nyc mocha --require ts-node/register 'src/**/__tests__/**/*.test.ts'",
"lint": "eslint --quiet --ignore-pattern scripts/bump-version.ts .",
Expand Down
1 change: 1 addition & 0 deletions src/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const levels = {

// Define level based on environment
const level = () => {
if (process.env.NODE_ENV === 'test' || process.env.LOG_LEVEL === 'silent') return 'silent';
const env = process.env.NODE_ENV || 'development';
const isDevelopment = env === 'development';
return isDevelopment ? 'debug' : 'warn';
Expand Down
3 changes: 3 additions & 0 deletions src/shared/appUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ import { Config, TlsMode } from '../shared/types';
*/
export function setupLogging(app: express.Application, config: Config): void {
// Set up morgan for logging, with optional logging into a file
if (process.env.NODE_ENV === 'test' || process.env.LOG_LEVEL === 'silent') {
return;
}
let middleware;
if (config.logFile) {
// create a write stream (in append mode)
Expand Down