feat(ebe, mbe): added error handling between expresses and kms#96
Merged
Conversation
alextse-bg
force-pushed
the
WP-5241
branch
9 times, most recently
from
7d100a5 to
4164293
Compare
pranavjain97
requested changes
Aug 1, 2025
pranavjain97
left a comment
pranavjain97
left a comment
Contributor
There was a problem hiding this comment.
Nice work.
- Fix the %s notation on all
loggerlogs, i dont think it works. Test it. - Add more test cases in
kmsClient.test.ts. - Fix merge conflicts
alextse-bg
force-pushed
the
WP-5241
branch
2 times, most recently
from
76cda34 to
b9cadf0
Compare
pranavjain97
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-5241