Merge pull request #12 from BitGo/allow_sighash_default

fix(sighashType): accept SIGHASH_DEFAULT

Author: brandonblack

src/lib/converter/input/sighashType.js

@@ -27,6 +27,10 @@ function check(data) {
 }
 exports.check = check;
 function canAdd(currentData, newData) {
-  return !!currentData && !!newData && currentData.sighashType === undefined;
+  return (
+    !!currentData &&
+    newData !== undefined &&
+    currentData.sighashType === undefined
+  );
 }
 exports.canAdd = canAdd;

src/tests/fixtures/methods.js

@@ -205,6 +205,14 @@ exports.fixtures = {
         'cHNidP8BAFMBAAAAAdSnb/ld4fTAFho+U+qHapHtlTMa6NAS2B+XE4SYzl2GAwAAAAD/' +
         '////AdIClkkAAAAAF6kU4Yhw8sKX+/ylTFxvZFx3RaW2btqHAAAAAAABAwQBAAAAAAA=',
     },
+    {
+      method: 'updateInput',
+      addInputOutput: true,
+      args: [0, { sighashType: 0 }],
+      expected:
+        'cHNidP8BAFMBAAAAAdSnb/ld4fTAFho+U+qHapHtlTMa6NAS2B+XE4SYzl2GAwAAAAD/' +
+        '////AdIClkkAAAAAF6kU4Yhw8sKX+/ylTFxvZFx3RaW2btqHAAAAAAABAwQAAAAAAAA=',
+    },
     {
       method: 'updateInput',
       addInputOutput: true,

ts_src/lib/converter/input/sighashType.ts

@@ -27,5 +27,9 @@ export function check(data: any): data is SighashType {
 }
 
 export function canAdd(currentData: any, newData: any): boolean {
-  return !!currentData && !!newData && currentData.sighashType === undefined;
+  return (
+    !!currentData &&
+    newData !== undefined &&
+    currentData.sighashType === undefined
+  );
 }

ts_src/tests/fixtures/methods.ts

@@ -204,6 +204,14 @@ export const fixtures = {
         'cHNidP8BAFMBAAAAAdSnb/ld4fTAFho+U+qHapHtlTMa6NAS2B+XE4SYzl2GAwAAAAD/' +
         '////AdIClkkAAAAAF6kU4Yhw8sKX+/ylTFxvZFx3RaW2btqHAAAAAAABAwQBAAAAAAA=',
     },
+    {
+      method: 'updateInput',
+      addInputOutput: true,
+      args: [0, { sighashType: 0 }],
+      expected:
+        'cHNidP8BAFMBAAAAAdSnb/ld4fTAFho+U+qHapHtlTMa6NAS2B+XE4SYzl2GAwAAAAD/' +
+        '////AdIClkkAAAAAF6kU4Yhw8sKX+/ylTFxvZFx3RaW2btqHAAAAAAABAwQAAAAAAAA=',
+    },
     {
       method: 'updateInput',
       addInputOutput: true,