fix(fixme): clean up old fixme comment

Author: byshing

official-ws/nodejs/lib/deltaParser.js

@@ -63,11 +63,7 @@ module.exports = {
     debug('partial: %s %s, data: %j', tableName, symbol, data);
     const dataArr = data.data || [];
     // Intitialize data.
-    // FIXME: we need to echo back `filter` with each partial, otherwise we can't tell the difference
-    // between no data for a symbol and a partial for a different symbol.
-    if (!client._data[tableName][symbol] || dataArr.length) {
-      client._data[tableName][symbol] = dataArr;
-    }
+    client._data[tableName][symbol] = dataArr;
     // Initialize keys.
     client._keys[tableName] = data.keys;
     // Return inserted data

official-ws/nodejs/test/client.test.js

@@ -111,3 +111,23 @@ test('Recovering after empty partial (* subscription)', async () => {
 
   expect(onOrder.callCount).toEqual(3);
 });
+
+test('Empty partial handling', async () => {
+  const onOrderBook = sinon.spy();
+
+  client.addStream('ETHYLDH23', 'orderBookL2_25', onOrderBook);
+  playback(client, data.orderbookSymboledEmptyPartial);
+
+  expect(client._data['orderBookL2_25']['ETHYLDH23']).toHaveLength(0)
+});
+
+test('Partial handling multiple stream', async () => {
+  const onOrderBook = sinon.spy();
+
+  client.addStream('XBTUSD', 'orderBookL2_25', onOrderBook);
+  client.addStream('ETHYLDH23', 'orderBookL2_25', onOrderBook);
+  playback(client, data.orderbookSymboledEmptyPartial);
+
+  expect(client._data['orderBookL2_25']['XBTUSD']).toHaveLength(2)
+  expect(client._data['orderBookL2_25']['ETHYLDH23']).toHaveLength(0)
+});