Merge pull request #121 from Bitcoin-com/ct-rawtransactions-unit

christroutner · web-flow · commit 9ecac0205c39 · 2019-06-11T11:34:40.000-07:00
Refactored RawTransactions Unit Tests
diff --git a/lib/RawTransactions.ts b/lib/RawTransactions.ts
@@ -22,14 +22,13 @@ export class RawTransactions {
 
         // Array of hexes
       } else if (Array.isArray(hex)) {
-        const options: AxiosRequestConfig = {
-          method: "POST",
-          url: `${this.restURL}rawtransactions/decodeRawTransaction`,
-          data: {
+        // Dev note: must use axios.post for unit test stubbing.
+        const response: AxiosResponse = await axios.post(
+          `${this.restURL}rawtransactions/decodeRawTransaction`,
+          {
             hexes: hex
           }
-        }
-        const response: AxiosResponse = await axios(options)
+        )
 
         return response.data
       }
@@ -52,14 +51,13 @@ export class RawTransactions {
 
         return response.data
       } else if (Array.isArray(script)) {
-        const options: AxiosRequestConfig = {
-          method: "POST",
-          url: `${this.restURL}rawtransactions/decodeScript`,
-          data: {
+        // Dev note: must use axios.post for unit test stubbing.
+        const response: AxiosResponse = await axios.post(
+          `${this.restURL}rawtransactions/decodeScript`,
+          {
             hexes: script
           }
-        }
-        const response: AxiosResponse = await axios(options)
+        )
 
         return response.data
       }
@@ -90,15 +88,14 @@ export class RawTransactions {
 
         return response.data
       } else if (Array.isArray(txid)) {
-        const options: AxiosRequestConfig = {
-          method: "POST",
-          url: `${this.restURL}rawtransactions/getRawTransaction`,
-          data: {
+        // Dev note: must use axios.post for unit test stubbing.
+        const response: AxiosResponse = await axios.post(
+          `${this.restURL}rawtransactions/getRawTransaction`,
+          {
             txids: txid,
             verbose: verbose
           }
-        }
-        const response: AxiosResponse = await axios(options)
+        )
 
         return response.data
       }
@@ -133,14 +130,14 @@ export class RawTransactions {
 
         // Array input
       } else if (Array.isArray(hex)) {
-        const options: AxiosRequestConfig = {
-          method: "POST",
-          url: `${this.restURL}rawtransactions/sendRawTransaction`,
-          data: {
+        
+        // Dev note: must use axios.post for unit test stubbing.
+        const response: AxiosResponse = await axios.post(
+          `${this.restURL}rawtransactions/sendRawTransaction`,
+          {
             hexes: hex
           }
-        }
-        const response: AxiosResponse = await axios(options)
+        )
 
         return response.data
       }
diff --git a/package.json b/package.json
@@ -10,6 +10,8 @@
     "test": "tsc && nyc mocha test/unit --timeout 60000 --exit",
     "test:no-build": "nyc mocha test/unit --timeout 60000 --exit",
     "test:integration": "TEST=integration nyc --reporter=text mocha --timeout 30000 test/integration",
+    "test:integration:local": "TEST=integration SERVER=local nyc --reporter=text mocha --timeout 30000 test/integration --exit",
+    "test:integration:stage": "TEST=integration SERVER=stage nyc --reporter=text mocha --timeout 30000 test/integration --exit",
     "coverage": "nyc report --reporter=text-lcov | coveralls",
     "build": "tsc"
   },
diff --git a/test/integration/address.js b/test/integration/address.js
@@ -11,8 +11,12 @@ const chai = require("chai")
 const assert = chai.assert
 
 const BITBOX = require("../../lib/BITBOX").BITBOX
-const bitbox = new BITBOX()
-//const axios = require("axios")
+let bitbox = new BITBOX()
+
+if (process.env.SERVER === "local")
+  bitbox = new BITBOX({ restURL: "http://localhost:3000/v2/" })
+if (process.env.SERVER === "stage")
+  bitbox = new BITBOX({ restURL: "https://rest.btctest.net/v2/" })
 
 // Inspect utility used for debugging.
 const util = require("util")
diff --git a/test/integration/block.js b/test/integration/block.js
@@ -7,7 +7,12 @@ const chai = require("chai")
 const assert = chai.assert
 
 const BITBOX = require("../../lib/BITBOX").BITBOX
-const bitbox = new BITBOX()
+let bitbox = new BITBOX()
+
+if (process.env.SERVER === "local")
+  bitbox = new BITBOX({ restURL: "http://localhost:3000/v2/" })
+if (process.env.SERVER === "stage")
+  bitbox = new BITBOX({ restURL: "https://rest.btctest.net/v2/" })
 
 // Inspect utility used for debugging.
 const util = require("util")
diff --git a/test/integration/blockchain.js b/test/integration/blockchain.js
@@ -11,7 +11,12 @@ const chai = require("chai")
 const assert = chai.assert
 
 const BITBOX = require("../../lib/BITBOX").BITBOX
-const bitbox = new BITBOX()
+let bitbox = new BITBOX()
+
+if (process.env.SERVER === "local")
+  bitbox = new BITBOX({ restURL: "http://localhost:3000/v2/" })
+if (process.env.SERVER === "stage")
+  bitbox = new BITBOX({ restURL: "https://rest.btctest.net/v2/" })
 
 // Inspect utility used for debugging.
 const util = require("util")
diff --git a/test/integration/price.js b/test/integration/price.js
@@ -1,6 +1,11 @@
 const assert = require("assert")
 const BITBOX = require("../../lib/BITBOX").BITBOX
-const bitbox = new BITBOX()
+let bitbox = new BITBOX()
+
+if (process.env.SERVER === "local")
+  bitbox = new BITBOX({ restURL: "http://localhost:3000/v2/" })
+if (process.env.SERVER === "stage")
+  bitbox = new BITBOX({ restURL: "https://rest.btctest.net/v2/" })
 
 describe("#price", () => {
   describe("#current", () => {
diff --git a/test/integration/rawtransaction.js b/test/integration/rawtransaction.js
@@ -9,7 +9,12 @@ const chai = require("chai")
 const assert = chai.assert
 
 const BITBOX = require("../../lib/BITBOX").BITBOX
-const bitbox = new BITBOX()
+let bitbox = new BITBOX()
+
+if (process.env.SERVER === "local")
+  bitbox = new BITBOX({ restURL: "http://localhost:3000/v2/" })
+if (process.env.SERVER === "stage")
+  bitbox = new BITBOX({ restURL: "https://rest.btctest.net/v2/" })
 
 // Inspect utility used for debugging.
 const util = require("util")
diff --git a/test/integration/transaction.js b/test/integration/transaction.js
@@ -7,7 +7,12 @@ const chai = require("chai")
 const assert = chai.assert
 
 const BITBOX = require("../../lib/BITBOX").BITBOX
-const bitbox = new BITBOX()
+let bitbox = new BITBOX()
+
+if (process.env.SERVER === "local")
+  bitbox = new BITBOX({ restURL: "http://localhost:3000/v2/" })
+if (process.env.SERVER === "stage")
+  bitbox = new BITBOX({ restURL: "https://rest.btctest.net/v2/" })
 
 // Inspect utility used for debugging.
 const util = require("util")
diff --git a/test/integration/util.js b/test/integration/util.js
@@ -7,7 +7,12 @@ const chai = require("chai")
 const assert = chai.assert
 
 const BITBOX = require("../../lib/BITBOX").BITBOX
-const bitbox = new BITBOX()
+let bitbox = new BITBOX()
+
+if (process.env.SERVER === "local")
+  bitbox = new BITBOX({ restURL: "http://localhost:3000/v2/" })
+if (process.env.SERVER === "stage")
+  bitbox = new BITBOX({ restURL: "https://rest.btctest.net/v2/" })
 
 // Inspect utility used for debugging.
 const util = require("util")
diff --git a/test/integration/z9-rate-limits.js b/test/integration/z9-rate-limits.js
@@ -8,7 +8,12 @@ const chai = require("chai")
 const assert = chai.assert
 
 const BITBOX = require("../../lib/BITBOX").BITBOX
-const bitbox = new BITBOX()
+let bitbox = new BITBOX()
+
+if (process.env.SERVER === "local")
+  bitbox = new BITBOX({ restURL: "http://localhost:3000/v2/" })
+if (process.env.SERVER === "stage")
+  bitbox = new BITBOX({ restURL: "https://rest.btctest.net/v2/" })
 
 // Inspect utility used for debugging.
 const util = require("util")
diff --git a/test/unit/Address.ts b/test/unit/Address.ts
@@ -18,7 +18,7 @@ const assert: Chai.AssertStatic = chai.assert
 const fixtures = require("./fixtures/Address.json")
 const Bitcoin = require("bitcoincashjs-lib")
 const sinon = require("sinon")
-const addressMock = require("./fixtures/address-mock.js")
+const addressMock = require("./mocks/address-mock.js")
 
 function flatten(arrays: any) {
   return [].concat.apply([], arrays)
diff --git a/test/unit/Block.ts b/test/unit/Block.ts
@@ -11,7 +11,7 @@ import { BlockDetailsResult } from "bitcoin-com-rest"
 // consts
 const bitbox: BITBOX = new BITBOX()
 const assert: Chai.AssertStatic = chai.assert
-const blockMock: any = require("./fixtures/block-mock")
+const blockMock: any = require("./mocks/block-mock")
 
 util.inspect.defaultOptions = {
   showHidden: true,
diff --git a/test/unit/Blockchain.ts b/test/unit/Blockchain.ts
@@ -11,7 +11,7 @@ import { BlockHeaderResult } from "bitcoin-com-rest"
 // consts
 const bitbox: BITBOX = new BITBOX()
 const assert: Chai.AssertStatic = chai.assert
-const blockchainMock = require("./fixtures/blockchain-mock")
+const blockchainMock = require("./mocks/blockchain-mock")
 
 util.inspect.defaultOptions = {
   showHidden: true,
diff --git a/test/unit/CashAccounts.ts b/test/unit/CashAccounts.ts
@@ -16,7 +16,7 @@ const assert: Chai.AssertStatic = chai.assert
 
 // TODO: port from require to import syntax
 const sinon = require("sinon")
-const cashAccountsMock = require("./fixtures/cashaccounts-mock.js")
+const cashAccountsMock = require("./mocks/cashaccounts-mock.js")
 
 util.inspect.defaultOptions = {
   showHidden: true,
diff --git a/test/unit/Price.ts b/test/unit/Price.ts
@@ -1,12 +1,19 @@
 // imports
-import * as assert from "assert";
+import * as chai from "chai"
 import { BITBOX } from "../../lib/BITBOX"
 import { Price } from "../../lib/Price"
+import axios from "axios"
+import * as sinon from "sinon"
 
 // consts
 const bitbox: BITBOX = new BITBOX()
+const assert: Chai.AssertStatic = chai.assert
 
 describe("#Price", (): void => {
+  let sandbox: any
+  beforeEach(() => (sandbox = sinon.sandbox.create()))
+  afterEach(() => sandbox.restore())
+
   describe("#PriceConstructor", (): void => {
     it("should create instance of Price", (): void => {
       const price: Price = new Price()
@@ -17,8 +24,15 @@ describe("#Price", (): void => {
   describe("#current", (): void => {
     describe("#single currency", (): void => {
       it("should get current price for single currency", async () => {
+        // Mock out data for unit test, to prevent live network call.
+        const data: any = 39229
+        const resolved: any = new Promise(r => r({ data: { price: data } }))
+        sandbox.stub(axios, "get").returns(resolved)
+
         const result = await bitbox.Price.current("usd")
-        assert.notEqual(0, result)
+        //console.log(`result: ${JSON.stringify(result, null, 2)}`)
+
+        assert.isNumber(result)
       })
     })
   })
diff --git a/test/unit/RawTransactions.ts b/test/unit/RawTransactions.ts
diff --git a/test/unit/mocks/address-mock.js b/test/unit/mocks/address-mock.js
diff --git a/test/unit/mocks/block-mock.js b/test/unit/mocks/block-mock.js
diff --git a/test/unit/mocks/blockchain-mock.js b/test/unit/mocks/blockchain-mock.js
diff --git a/test/unit/mocks/cashaccounts-mock.js b/test/unit/mocks/cashaccounts-mock.js
diff --git a/test/unit/mocks/rawtransactions-mock.js b/test/unit/mocks/rawtransactions-mock.js
