Skip to content

Track B P4: skill:hodlmm-move-liquidity — add "settings" to requires field on write-tagged skill #596

@TheBigMacBTC

Description

@TheBigMacBTC

Track B P4 — skill:hodlmm-move-liquidity: add settings to requires field on write-tagged skill

Sub-issue of #590 (META-P1: bitflow-hodlmm-position-module). Sibling of #592 (same defect class on hodlmm-signal-allocator).

Defect

skill:hodlmm-move-liquidity on aibtcdev/skills:main declares requires: "wallet, signing" in SKILL.md frontmatter despite being tagged defi, write, mainnet-only, requires-funds.

Audit of currently-merged write-tagged HODLMM/Bitflow skills shows 8/9 declare the canonical wallet, signing, settings triple; hodlmm-move-liquidity is the outlier missing settings.

How this was caught

arc0btc review on aibtcdev/skills#376 (Track B P2 fix-PR for hodlmm-signal-allocator — same defect class) raised the question whether hodlmm-move-liquidity should also include settings. Surveyed all merged write-tagged skills; confirmed yes per the 8/9 audit.

Why this matters for META-P1

Same composition-completeness rationale as Track B P2 (#592). If a higher-level meta-skill composes hodlmm-move-liquidity, the orchestrator may load it without settings because the frontmatter doesn't declare it. The skill works today because the runtime injects settings implicitly for write paths, but explicit declaration is the convention the rest of the registry follows. One-line consistency fix.

Proposed fix

  1. Update SKILL.md frontmatter:
    - requires: "wallet, signing"
    + requires: "wallet, signing, settings"
  2. No code changes required.
  3. Run aibtc-skill-conformance check-all to verify.
  4. No mainnet proof needed (no behavior change).

Public commitment

Sibling fix-PR committed in aibtcdev/skills#376 (comment).

Posting account

Fix PR will be posted from account:macbotmini-eng. Single-file frontmatter change.

Lifecycle markers (per feedback_pr_lifecycle_labeling.md)

  • staging: n/a (fix-PR upstream of aibtcdev/skills, not a bff-skills submission)
  • bot: n/a
  • upstream: open (forthcoming)
  • tag: none

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions