Skip to content

src: use Bitgesell terms in RPC and GUI help#295

Open
pinehill99 wants to merge 1 commit into
BitgesellOfficial:masterfrom
pinehill99:patch-12
Open

src: use Bitgesell terms in RPC and GUI help#295
pinehill99 wants to merge 1 commit into
BitgesellOfficial:masterfrom
pinehill99:patch-12

Conversation

@pinehill99
Copy link
Copy Markdown

Summary

  • replace stale Bitcoin terminology in user-facing RPC help and Qt status tips
  • use Bitgesell address / newly generated coins / Partially Signed Bitgesell Transaction where those strings are shown to BGL users
  • leave bitcoin: URI protocol text untouched

Validation

  • git diff --check
  • git grep -n -E 'newly generated bitcoin|bitcoin address|sending bitcoins|sending bitcoin|Partially Signed Bitcoin Transaction' -- src/rpc/mining.cpp src/rpc/output_script.cpp src/rpc/signmessage.cpp src/wallet/rpc/encrypt.cpp src/qt/BGLgui.cpp || true\n\nNote: python3 test/lint/lint-format-strings.py currently reports pre-existing repository-wide failures in src/precompute_ecmult_gen.c and contrib/devtools/BGL-tidy/example_logprintf.cpp, outside this patch.\n\nRefs BGL PR bounty hunt ($10000 overall budget) #39, BGL (Bitgesell) Bounty/Improvement Program ($50000 budget) #81

@MyTH-zyxeon
Copy link
Copy Markdown

Maintainers: this looks like a reasonable #81 cleanup slice because it narrows user-facing inherited Bitcoin wording in RPC help and Qt status text without changing runtime logic.

Acceptance checks I would keep explicit before merge/payout:

  • Confirm each renamed string is actually user-facing Bitgesell product language, not an external protocol/API term that intentionally stays Bitcoin-named. The PR body already calls out the bitcoin: URI exception; I would also double-check any RPC/help text that mirrors upstream Bitcoin RPC wording for compatibility expectations.
  • In src/wallet/rpc/encrypt.cpp, confirm Partially Signed Bitgesell Transaction is consistent with the rest of the codebase and docs. If the project intentionally keeps the PSBT acronym expansion upstream-compatible, that wording choice should be deliberate rather than mixed.
  • For the mining and signmessage help text, confirm there are no neighboring stale strings still saying bitcoin / bitcoins in the same command help paths, so this does not leave partially-updated UX copy.
  • Since this touches only user-facing strings, a focused grep/diff proof is fine, but maintainers may still want one quick UI/RPC smoke pass before treating it as accepted BGL (Bitgesell) Bounty/Improvement Program ($50000 budget) #81 work.

From the visible diff, this is a narrow terminology cleanup rather than consensus/wallet behavior change, which matches the lower-risk review lane described in #81.

@pinehill99
Copy link
Copy Markdown
Author

Thanks for the careful acceptance-check framing.

I rechecked the current PR diff and want to keep the scope explicit:

  • The changed strings are user-facing RPC help text or Qt status tips only: src/rpc/mining.cpp, src/rpc/output_script.cpp, src/rpc/signmessage.cpp, src/wallet/rpc/encrypt.cpp, and src/qt/BGLgui.cpp.
  • I intentionally left protocol / compatibility wording outside this patch. In particular, the PR body already calls out that bitcoin: URI protocol text is not part of this cleanup.
  • The PSBT change is limited to the Qt tooltip expansion shown to users; command names, file format handling, and PSBT behavior are not changed.
  • The focused grep check in the PR body is the local proof for the stale phrases touched by this patch:
    git grep -n -E 'newly generated bitcoin|bitcoin address|sending bitcoins|sending bitcoin|Partially Signed Bitcoin Transaction' -- src/rpc/mining.cpp src/rpc/output_script.cpp src/rpc/signmessage.cpp src/wallet/rpc/encrypt.cpp src/qt/BGLgui.cpp || true

I agree this should stay in the lower-risk #81 terminology / UX-copy lane. Maintainers should still make the final wording call on whether Partially Signed Bitgesell Transaction is preferred project language for the UI tooltip, and can run any broader UI/RPC smoke they want before treating it as accepted bounty work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants