Skip to content

build: fix Windows resource metadata names#338

Open
francosmit94-web wants to merge 1 commit into
BitgesellOfficial:masterfrom
francosmit94-web:fix-windows-resource-metadata
Open

build: fix Windows resource metadata names#338
francosmit94-web wants to merge 1 commit into
BitgesellOfficial:masterfrom
francosmit94-web:fix-windows-resource-metadata

Conversation

@francosmit94-web
Copy link
Copy Markdown

Summary

Fixes mismatched Windows version-resource metadata for BGL command-line tools:

  • BGL-cli resource now identifies BGL-cli.exe
  • BGL-tx resource now identifies BGL-tx.exe
  • BGL-util resource now identifies BGL-util.exe
  • BGL-wallet resource now identifies BGL-wallet.exe

The resource files were shifted across tools, so Windows file properties could show the wrong executable name/product metadata.

References #32.

Verification

  • Verified each touched resource file has matching InternalName, OriginalFilename, and ProductName values for its executable.
  • git diff --check

@MyTH-zyxeon
Copy link
Copy Markdown

Review-assist note for #32 / #81 / #338:

This is a strong low-risk Windows packaging/metadata cleanup: the visible diff realigns the version-resource metadata for BGL-cli, BGL-tx, BGL-util, and BGL-wallet without touching runtime code or consensus behavior.

Acceptance checks I would keep explicit before merge/payout:

  • Confirm each .rc file now matches the executable it is compiled into: InternalName, OriginalFilename, ProductName, and FileDescription should agree for all four tools.
  • If maintainers can build Windows artifacts, inspect file properties for the generated .exe files to prove the metadata no longer appears shifted between tools.
  • Check whether BGLd resource metadata is intentionally outside this PR. The old BGL-tx-res.rc value previously pointed at BGLd, so a quick grep over all *-res.rc files would confirm there is no remaining shifted resource block.
  • Treat this as packaging/UX metadata under the BGL PR bounty hunt #32/BGL (Bitgesell) Bounty/Improvement Program ($50000 budget) #81 bounty lane, not a wallet/node behavior change; no chain or key handling should be needed for review.

I did not run builds, install dependencies, start nodes, use wallet keys, or perform any live-chain action. This is a maintainer-facing review checklist to help decide whether #338 should be accepted as a focused Windows metadata fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants