Skip to content

Feature: add Ethereum to BSC Mainnet network switch#19

Open
Ckirwa wants to merge 3 commits into
BitgesellOfficial:mainfrom
Ckirwa:feature-bsc-network-change
Open

Feature: add Ethereum to BSC Mainnet network switch#19
Ckirwa wants to merge 3 commits into
BitgesellOfficial:mainfrom
Ckirwa:feature-bsc-network-change

Conversation

@Ckirwa
Copy link
Copy Markdown

@Ckirwa Ckirwa commented Nov 4, 2022

Summary

  • Add feature to allow user switch from Ethereum(Goerli) to BSC Mainnet

@Ckirwa
Copy link
Copy Markdown
Author

Ckirwa commented Nov 4, 2022

Hi @wu-emma @van-orton
Check this out ( #19 )

@Ckirwa
Copy link
Copy Markdown
Author

Ckirwa commented Nov 8, 2022

Hi @wu-emma @van-orton

Uses underlying MetaMask APIs to add BSC Mainnet networks. Looks like this when in use:

bnb-metamask-popup
bsc-switched
switch
switch-to-bsc1

@arantes-bgl
Copy link
Copy Markdown

Add resources on the bridge so they can be used in a trusted wallet

@MyTH-zyxeon
Copy link
Copy Markdown

Maintainers: quick review-assist checklist for #19 (BSC Mainnet network switch).

If you still want this feature merged, here are the main acceptance checks I’d suggest before approving:

  • Uses wallet_addEthereumChain / wallet_switchEthereumChain with the correct BSC chainId (0x38), RPC URLs, block explorer URL, native currency metadata.
  • Error handling: if the user rejects the MetaMask prompt, the UI should remain on the prior network and show a non-fatal message.
  • Does not hardcode deprecated Goerli assumptions (Goerli is sunset); ideally the “source network” is generic (any EVM testnet/mainnet) or configurable.
  • No sensitive values in the repo (API keys), and the added network metadata is safe to ship.
  • Optional: add a small unit/integration test around the “switch network” helper (or at least a manual test recipe in the PR body).

If you confirm whether the bridge is intended to support BSC mainnet today (vs. only testnets), I can follow up with a tighter acceptance recipe or a minimal patch PR to align with your preferred network list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants