Fix postMessage object listener instrumentation and JSDOM compatibility#25
Fix postMessage object listener instrumentation and JSDOM compatibility#25xkilldash9x merged 1 commit intomainfrom
Conversation
This commit updates `instrumentPostMessage` in `taint_shim.js` to correctly instrument event listeners that are objects with a `handleEvent` method, ensuring security checks within these methods are analyzed. It also addresses JSDOM environment quirks discovered during testing by ensuring `window.addEventListener` is explicitly patched if it differs from the prototype, and adds proper cache cleanup to support robust testing. Fixes bug where object-based event listeners were ignored.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This commit updates `instrumentPostMessage` in `taint_shim.js` to correctly instrument event listeners that are objects with a `handleEvent` method, ensuring security checks within these methods are analyzed. It also addresses JSDOM environment quirks discovered during testing by ensuring `window.addEventListener` is explicitly patched if it differs from the prototype, and adds proper cache cleanup to support robust testing. Fixes bug where object-based event listeners were ignored. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
1 participant
Updated
taint_shim.jsto support object listeners inpostMessageinstrumentation. Added handling for JSDOM environments wherewindow.addEventListeneris own property. Cleared instrumentation caches in cleanup routine. Added regression test case.PR created automatically by Jules for task 1098246405047230223 started by @xkilldash9x