⚡ Optimize GenerateTopologyHash allocations#10
Conversation
- Pre-allocate `calls` slice to avoid resizing. - Replace `strings.Builder` loop with reusable `[]byte` buffer and `strconv.AppendInt`. - Reduces allocations by ~50% and execution time by ~23%. Co-authored-by: xkilldash9x <223238109+xkilldash9x@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Optimized
GenerateTopologyHashinpkg/detection/engine.goby:callsslice to avoid resizing.strings.Builderandstrconv.Itoainside the loop with a reusable[]bytebuffer andstrconv.AppendInt.🎯 Why:
The previous implementation allocated a new
strings.Builder(and underlying buffer) and multiple strings (viaItoa) for every call signature in the loop. This created significant memory pressure and GC overhead in hot paths.📊 Measured Improvement:
Benchmark
BenchmarkGenerateTopologyHashresults:35031 ns/op->27030 ns/op)215 allocs/op->108 allocs/op)12328 B/op->8856 B/op)PR created automatically by Jules for task 515067491780145595 started by @xkilldash9x