Add GTE-Reranker-ModernBERT-Base support with reranking example and tests#62
Open
afanjul wants to merge 2 commits into
Open
Add GTE-Reranker-ModernBERT-Base support with reranking example and tests#62afanjul wants to merge 2 commits into
afanjul wants to merge 2 commits into
Conversation
…ests Co-Authored-By: Alex Fan <afanjul@palbin.com>
…modernbert-support Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Alex Fan <afanjul@palbin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds full support for the Alibaba-NLP/gte-reranker-modernbert-base cross-encoder reranker model.
The existing
modernbert.pyalready handledModernBertForSequenceClassificationarchitecture, but it lacked tests, documentation, and thegenerate()function didn't accept text pairs needed for reranking.Changes:
mlx_embeddings/utils.py:generate()type signature to acceptList[List[str]](text pairs for reranking)upload_to_hub()forModernBertForSequenceClassificationarchitecturescomparison forModernBertForMaskedLMwas comparing a list to a string instead of a listmlx_embeddings/tests/test_models.py:test_modernbert_model_sequence_classificationtest that validates the model works correctly with sigmoid output range verificationREADME.md:Alibaba-NLP/gte-reranker-modernbert-base