fix: prevent crash when args.adapter_file is None in sft_trainer#921
Open
JasonOA888 wants to merge 1 commit into
Open
fix: prevent crash when args.adapter_file is None in sft_trainer#921JasonOA888 wants to merge 1 commit into
JasonOA888 wants to merge 1 commit into
Conversation
Add defensive fallback to 'adapters.safetensors' when adapter_file is None, and ensure parent directory exists before saving. Closes Blaizzy#908
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sft_trainer.pycrashes withTypeError: argument should be a str or an os.PathLike objectwhenargs.adapter_fileisNone. This happens whenTrainingArgsis constructed with an explicitNonevalue foradapter_file(e.g. from programmatic usage).Fix
adapter_file = args.adapter_file or "adapters.safetensors"at both save points (checkpoint and final)FileNotFoundErrorBoth the checkpoint save (line ~471) and final save (line ~484) are covered.
Closes #908