Improve VS project creation UX with job list refresh and spinners#43
Merged
Merged
Conversation
…roject, add save/run button spinners
There was a problem hiding this comment.
Pull request overview
This PR improves the job/project creation experience by adding clearer in-progress UI feedback (busy indicators/overlays) and by attempting to register newly created VS projects as jobs so they appear on the dashboard, along with a small solution-template organization tweak.
Changes:
- After project creation, attempt to create a corresponding job and refresh the job list (
BlazorOrchestrator.WebHome page). - Add a saving overlay and mark the “Run” split button as busy during execution (
JobCreatorTemplateHome page). - Group core dependency projects under a
/Dependencies/solution folder in the job-creator solution template.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/BlazorOrchestrator.Web/JobTemplate/JobCreatorTemplate.slnx.template | Organizes the Core project under a /Dependencies/ solution folder in the template. |
| src/BlazorOrchestrator.Web/Components/Pages/Home.razor | Registers a newly created project as a job (with warning on failure) and refreshes the job list. |
| src/BlazorDataOrchestrator.JobCreatorTemplate/Components/Pages/Home.razor | Adds saving overlay and busy indicator on Run to prevent duplicate submissions / improve feedback. |
Comment on lines
+899
to
+903
| var org = await JobService.GetDefaultOrganizationAsync(); | ||
| if (org != null) | ||
| { | ||
| await JobService.CreateJobAsync(projectName, org.Id); | ||
| } |
| } | ||
| catch (Exception jobEx) | ||
| { | ||
| NotificationService.Notify(NotificationSeverity.Warning, "Warning", $"Project created but failed to register job: {jobEx.Message}"); |
Comment on lines
+211
to
+212
| <RadzenText TextStyle="TextStyle.H5" Style="margin: 0; color: #333; font-weight: 600;">Saving & Compiling…</RadzenText> | ||
| <RadzenText TextStyle="TextStyle.Body2" Style="margin: 0; color: #666;">Please wait while your code is being saved and validated</RadzenText> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several user experience improvements and backend integration enhancements to the job creation workflow in the Blazor Data Orchestrator application. The main changes focus on providing better visual feedback during save and execute operations, ensuring jobs are properly registered in the database, and improving project organization.
User Experience Improvements:
Home.razor).isSaving, allowing the overlay to render before the save operation proceeds (Home.razor).IsBusy) while code execution is in progress, preventing duplicate submissions and clarifying status for users (Home.razor).Backend Integration:
Home.razor).Project Structure:
JobCreatorTemplate.slnx.template) to organize dependencies into a/Dependencies/folder, improving project structure clarity.