URL-encode media filenames#42
Open
ccollins476ad wants to merge 1 commit into
Open
Conversation
This fixes a bug that prevented the browser from displaying media files with special characters in their filenames. The fix is to URL-encode media file paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug that prevented the browser from displaying media files with special characters in their filenames. The fix is to URL-encode media file paths.
I have only tested this on:
So I am not sure if this issue affects other browsers.
I was specifically seeing this problem for galleries when the post subject contains a
?character.EDIT: I do not ever use python, so I am sure this is not the right way to fix this issue. I'm leaving the PR because I believe it fixes a legitimate issue, but feel free to close and apply a better fix.