-
Notifications
You must be signed in to change notification settings - Fork 3
Allow factory reset without PERSISTENT_DATA_BLOCK_SERVICE #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benys
wants to merge
17
commits into
BlissOS:typhoon-x86
Choose a base branch
from
benys:typhoon-x86
base: typhoon-x86
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0ea6224
Add Manufacturer to device info
cwhuang c5de074
Add information about OpenGL driver version
cwhuang 91fbb56
Adding our own custom serial number property
hmtheboy154 f3c0695
Replace Blissify dashboard with BlissOS logo
hmtheboy154 47fc224
Resize BlissOS's Blissify logo
hmtheboy154 1d6be9b
Use getRealSize() to get screen resolution
hmtheboy154 c6d133e
Replace with a tablet drawable on Device name
hmtheboy154 3fbb47f
Changes to Processor info for BlissOS
hmtheboy154 1a1de41
Blissify new Settings with BlissOS assets
hmtheboy154 d49f062
Remove Navbar height checking on the show resolution
hmtheboy154 8c0e465
Show rotation in Resolution info
hmtheboy154 94dc693
Show DPI in Resolution info
hmtheboy154 bbbd961
Swap width and height if width < height
hmtheboy154 7fddc82
Bypass restrictions on low RAM devices or Go builds [1/3]
hmtheboy154 dac4830
Include SystemUISharedLib for Taskbar switch
hmtheboy154 bf0fe46
Settings: Network setup UI changes for SUW
mikeNG fd3defc
Allow factory reset without PERSISTENT_DATA_BLOCK_SERVICE
dimorinny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,18 @@ | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" android:width="24dp" android:height="24dp" android:viewportWidth="24" android:viewportHeight="24"> | ||
| <group> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M11.97 0c0.83 0.57 5.1 3.86 0 6.96-5.1-3.1-0.84-6.4 0-6.96Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M8.44 8.36c1.4-5.76-3.97-5.1-4.97-4.92-0.18 0.98-0.85 6.3 4.97 4.92Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M7.03 11.96c-3.13-5.05-6.46-0.82-7.03 0 0.57 0.83 3.9 5.06 7.03 0Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M16.97 11.96c3.13-5.05 6.46-0.82 7.03 0-0.57 0.83-3.9 5.06-7.03 0Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M20.53 3.44c-1-0.19-6.37-0.84-4.97 4.92 5.82 1.38 5.16-3.94 4.97-4.92Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M3.63 20.54c1 0.18 6.34 0.86 4.94-4.9-5.82-1.38-5.16 3.94-4.97 4.92l0.03-0.02Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M12.08 24c0.84-0.57 5.1-3.86 0-6.96-5.1 3.1-0.83 6.4 0 6.96Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M15.68 15.64c-1.4 5.76 3.98 5.1 4.98 4.92 0.18-0.98 0.84-6.3-4.98-4.92Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M12.86 9.8l-0.88-1.18-0.89 1.18L9.62 9.6l0.22 1.45-1.2 0.88 1.2 0.87-0.22 1.46 1.47-0.22 0.89 1.18 0.88-1.18 1.47 0.22-0.21-1.46 1.19-0.87-1.2-0.88 0.22-1.45-1.47 0.21Z"/> | ||
| </group> | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="24dp" | ||
| android:height="24dp" | ||
| android:viewportWidth="512" | ||
| android:viewportHeight="512"> | ||
| <group> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M264.58 460.8c69.55-8.4 135.02-40.98 182.37-96.9 47.35-55.93 68.35-125.48 64.62-194.82-69.55 8.4-135.01 40.97-182.37 96.9-47.34 55.93-68.35 125.48-64.62 194.82Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M264.58 460.8c69.55-8.4 135.02-40.98 182.37-96.9 47.35-55.93 68.35-125.48 64.62-194.82-69.55 8.4-135.01 40.97-182.37 96.9-47.34 55.93-68.35 125.48-64.62 194.82Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M247.41 460.8c3.73-69.34-17.28-138.9-64.63-194.82-47.34-55.93-112.8-88.5-182.36-96.9-3.73 69.34 17.28 138.89 64.63 194.81 47.34 55.93 112.8 88.5 182.36 96.91Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M247.41 460.8c3.73-69.34-17.28-138.9-64.63-194.82-47.34-55.93-112.8-88.5-182.36-96.9-3.73 69.34 17.28 138.89 64.63 194.81 47.34 55.93 112.8 88.5 182.36 96.91Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:fillType="evenOdd" android:pathData="M305.55 148.13c-12.68-26.1-29.4-50.1-49.4-71.33-20.06 21.28-36.81 45.37-49.5 71.54 19.5 20.15 36.22 43.22 49.34 68.89 13.18-25.77 29.96-48.9 49.56-69.1Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:fillType="evenOdd" android:pathData="M305.55 148.13c-12.68-26.1-29.4-50.1-49.4-71.33-20.06 21.28-36.81 45.37-49.5 71.54 19.5 20.15 36.22 43.22 49.34 68.89 13.18-25.77 29.96-48.9 49.56-69.1Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:fillType="evenOdd" android:pathData="M98.09 184.45c2.9-28.89 10.32-57.19 21.82-83.98 55.81 28.12 101.9 73.28 129.05 131.52-2.45 5.54-4.73 11.19-6.85 16.94-7.26 19.77-12.18 39.85-14.9 59.98-9.5-17.94-21.03-35.1-34.65-51.2-26.77-31.6-59.03-56.07-94.47-73.26Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:fillType="evenOdd" android:pathData="M98.09 184.45c2.9-28.89 10.32-57.19 21.82-83.98 55.81 28.12 101.9 73.28 129.05 131.52-2.45 5.54-4.73 11.19-6.85 16.94-7.26 19.77-12.18 39.85-14.9 59.98-9.5-17.94-21.03-35.1-34.65-51.2-26.77-31.6-59.03-56.07-94.47-73.26Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:fillType="evenOdd" android:pathData="M413.9 184.45c-2.9-28.89-10.33-57.19-21.83-83.98-62.45 31.47-112.73 84.27-137.92 152.88-9.45 25.72-14.75 51.98-16.25 78.13 8.34 19.79 14.35 40.32 18.1 61.21 8.68-48.51 29.63-95.06 63.44-134.98 26.75-31.6 59.02-56.06 94.46-73.26Z"/> | ||
| <path android:fillColor="?android:attr/colorAccent" android:fillType="evenOdd" android:pathData="M413.9 184.45c-2.9-28.89-10.33-57.19-21.83-83.98-62.45 31.47-112.73 84.27-137.92 152.88-9.45 25.72-14.75 51.98-16.25 78.13 8.34 19.79 14.35 40.32 18.1 61.21 8.68-48.51 29.63-95.06 63.44-134.98 26.75-31.6 59.02-56.06 94.46-73.26Z"/> | ||
| </group> | ||
| </vector> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,18 @@ | ||
| <vector android:height="24dp" android:viewportHeight="512" | ||
| android:viewportWidth="512" android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M0.882,255.233C13.111,237.552 83.286,147.431 149.977,255.233L149.096,255.233C82.404,363.034 12.23,272.913 0,255.233L0.882,255.233Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M74.671,73.911C95.949,69.969 209.95,55.359 180.097,178.265L179.474,177.648C55.305,207.197 70.065,94.355 74.047,73.294L74.671,73.911Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M255.225,0.873C273.087,12.978 364.135,82.438 255.225,148.452L255.225,147.579C146.315,81.566 237.363,12.106 255.225,-0L255.225,0.873Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M511.118,255.233C498.889,237.552 428.714,147.431 362.023,255.233L362.904,255.233C429.596,363.034 499.77,272.913 512,255.233L511.118,255.233Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M437.33,73.911C416.051,69.969 302.05,55.359 331.903,178.265L332.526,177.648C456.695,207.197 441.935,94.355 437.953,73.294L437.33,73.911Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M77.302,438.089C98.58,442.031 212.581,456.641 182.728,333.735L182.105,334.352C57.936,304.803 72.696,417.645 76.678,438.706L77.302,438.089Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M257.856,511.128C275.718,499.022 366.766,429.562 257.856,363.549L257.856,364.421C148.946,430.434 239.994,499.895 257.856,512L257.856,511.128Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M439.961,438.089C418.683,442.031 304.681,456.641 334.534,333.735L335.157,334.352C459.326,304.803 444.566,417.645 440.584,438.706L439.961,438.089Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M255.616,183.917L274.511,209.084L305.85,204.513L301.232,235.533L326.658,254.236L301.232,272.938L305.85,303.959L274.511,299.387L255.616,324.555L236.721,299.387L205.382,303.959L210,272.938L184.574,254.236L210,235.533L205.382,204.513L236.721,209.084L255.616,183.917Z"/> | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="24dp" | ||
| android:height="24dp" | ||
| android:viewportWidth="512" | ||
| android:viewportHeight="512"> | ||
| <group> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:pathData="M264.58 460.8c69.55-8.4 135.02-40.98 182.37-96.9 47.35-55.93 68.35-125.48 64.62-194.82-69.55 8.4-135.01 40.97-182.37 96.9-47.34 55.93-68.35 125.48-64.62 194.82Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:pathData="M264.58 460.8c69.55-8.4 135.02-40.98 182.37-96.9 47.35-55.93 68.35-125.48 64.62-194.82-69.55 8.4-135.01 40.97-182.37 96.9-47.34 55.93-68.35 125.48-64.62 194.82Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:pathData="M247.41 460.8c3.73-69.34-17.28-138.9-64.63-194.82-47.34-55.93-112.8-88.5-182.36-96.9-3.73 69.34 17.28 138.89 64.63 194.81 47.34 55.93 112.8 88.5 182.36 96.91Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:pathData="M247.41 460.8c3.73-69.34-17.28-138.9-64.63-194.82-47.34-55.93-112.8-88.5-182.36-96.9-3.73 69.34 17.28 138.89 64.63 194.81 47.34 55.93 112.8 88.5 182.36 96.91Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M305.55 148.13c-12.68-26.1-29.4-50.1-49.4-71.33-20.06 21.28-36.81 45.37-49.5 71.54 19.5 20.15 36.22 43.22 49.34 68.89 13.18-25.77 29.96-48.9 49.56-69.1Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M305.55 148.13c-12.68-26.1-29.4-50.1-49.4-71.33-20.06 21.28-36.81 45.37-49.5 71.54 19.5 20.15 36.22 43.22 49.34 68.89 13.18-25.77 29.96-48.9 49.56-69.1Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M98.09 184.45c2.9-28.89 10.32-57.19 21.82-83.98 55.81 28.12 101.9 73.28 129.05 131.52-2.45 5.54-4.73 11.19-6.85 16.94-7.26 19.77-12.18 39.85-14.9 59.98-9.5-17.94-21.03-35.1-34.65-51.2-26.77-31.6-59.03-56.07-94.47-73.26Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M98.09 184.45c2.9-28.89 10.32-57.19 21.82-83.98 55.81 28.12 101.9 73.28 129.05 131.52-2.45 5.54-4.73 11.19-6.85 16.94-7.26 19.77-12.18 39.85-14.9 59.98-9.5-17.94-21.03-35.1-34.65-51.2-26.77-31.6-59.03-56.07-94.47-73.26Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M413.9 184.45c-2.9-28.89-10.33-57.19-21.83-83.98-62.45 31.47-112.73 84.27-137.92 152.88-9.45 25.72-14.75 51.98-16.25 78.13 8.34 19.79 14.35 40.32 18.1 61.21 8.68-48.51 29.63-95.06 63.44-134.98 26.75-31.6 59.02-56.06 94.46-73.26Z"/> | ||
| <path android:fillColor="?android:attr/colorPrimary" android:fillType="evenOdd" android:pathData="M413.9 184.45c-2.9-28.89-10.33-57.19-21.83-83.98-62.45 31.47-112.73 84.27-137.92 152.88-9.45 25.72-14.75 51.98-16.25 78.13 8.34 19.79 14.35 40.32 18.1 61.21 8.68-48.51 29.63-95.06 63.44-134.98 26.75-31.6 59.02-56.06 94.46-73.26Z"/> | ||
| </group> | ||
| </vector> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- | ||
| Copyright (C) 2021 The LineageOS Project | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:width="24dp" | ||
| android:height="24dp" | ||
| android:viewportWidth="24" | ||
| android:viewportHeight="24"> | ||
|
|
||
| <path | ||
| android:fillColor="?android:attr/colorPrimary" | ||
| android:pathData="M12,2A8,8 0 0,0 4,10C4,14.03 7,17.42 11,17.93V19H10A1,1 0 0,0 9,20H2V22H9A1,1 0 0,0 10,23H14A1,1 0 0,0 15,22H22V20H15A1,1 0 0,0 14,19H13V17.93C17,17.43 20,14.03 20,10A8,8 0 0,0 12,2M12,4C12,4 12.74,5.28 13.26,7H10.74C11.26,5.28 12,4 12,4M9.77,4.43C9.5,4.93 9.09,5.84 8.74,7H6.81C7.5,5.84 8.5,4.93 9.77,4.43M14.23,4.44C15.5,4.94 16.5,5.84 17.19,7H15.26C14.91,5.84 14.5,4.93 14.23,4.44M6.09,9H8.32C8.28,9.33 8.25,9.66 8.25,10C8.25,10.34 8.28,10.67 8.32,11H6.09C6.03,10.67 6,10.34 6,10C6,9.66 6.03,9.33 6.09,9M10.32,9H13.68C13.72,9.33 13.75,9.66 13.75,10C13.75,10.34 13.72,10.67 13.68,11H10.32C10.28,10.67 10.25,10.34 10.25,10C10.25,9.66 10.28,9.33 10.32,9M15.68,9H17.91C17.97,9.33 18,9.66 18,10C18,10.34 17.97,10.67 17.91,11H15.68C15.72,10.67 15.75,10.34 15.75,10C15.75,9.66 15.72,9.33 15.68,9M6.81,13H8.74C9.09,14.16 9.5,15.07 9.77,15.56C8.5,15.06 7.5,14.16 6.81,13M10.74,13H13.26C12.74,14.72 12,16 12,16C12,16 11.26,14.72 10.74,13M15.26,13H17.19C16.5,14.16 15.5,15.07 14.23,15.57C14.5,15.07 14.91,14.16 15.26,13Z" /> | ||
| </vector> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| <vector android:height="24dp" android:viewportHeight="24" android:viewportWidth="24" | ||
| android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <path android:fillColor="?android:attr/colorAccent" android:pathData="M21,4L3,4c-1.1,0 -2,0.9 -2,2v12c0,1.1 0.9,2 2,2h18c1.1,0 1.99,-0.9 1.99,-2L23,6c0,-1.1 -0.9,-2 -2,-2zM19,18L5,18L5,6h14v12z"/> | ||
| </vector> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,8 +20,8 @@ | |
|
|
||
| <com.google.android.material.card.MaterialCardView | ||
| android:id="@+id/phone_image" | ||
| android:layout_width="100dp" | ||
| android:layout_height="205dp" | ||
| android:layout_width="240dp" | ||
| android:layout_height="135dp" | ||
| android:layout_marginTop="30.0dip" | ||
| android:layout_marginBottom="36.0dip" | ||
| android:layout_marginStart="30.0dp" | ||
|
|
@@ -32,15 +32,15 @@ | |
|
|
||
| <com.android.utils.aboutWallpaperView | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:scaleType="centerCrop" | ||
| android:gravity="center" | ||
| android:elevation="0dp" | ||
| android:contentDescription="@null" | ||
| android:orientation="vertical" /> | ||
| android:layout_height="match_parent" | ||
| android:scaleType="centerCrop" | ||
| android:gravity="center" | ||
| android:elevation="0dp" | ||
| android:contentDescription="@null" | ||
| android:orientation="horizontal" /> | ||
|
Comment on lines
33
to
+40
|
||
|
|
||
| <ImageView | ||
| android:layout_width="50dp" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:layout_gravity="center" | ||
| android:src="@drawable/bliss_logo" /> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The orientation is being changed from "vertical" to "horizontal" without explanation. This changes the layout behavior significantly. Please verify that this change is intentional and correctly renders the about phone UI on all device form factors.