fix: handle quoted wildcard "*" in scoreboard commands to prevent codeLens crash (#482)

Using `scoreboard players reset "*" test` crashes the
`textDocument/codeLens` request because the quoted `"*"` was not
recognized as a wildcard, causing it to be registered as a fake entity
with id `*`, which then broke regex construction in the codeLens handler
(`/\b*\b/g` → "Nothing to repeat").

## Changes

- **`objective/process.ts`** — `CheckPlayer` now uses `Text.UnQuote()`
before comparing against `*`, so `"*"` is correctly excluded from fake
entity registration
- **`commands.ts`** — `mcfunction_diagnoseparameter` wildcard check
extended to also match `"*"`, skipping diagnosis for quoted wildcards
- **`selector.ts`** — `Selector.isSelector` now accepts `"*"` as valid
when `wildcard: true`
- **`code-lens/on-request.ts`** — Added `escapeRegex()` to sanitize IDs
before inserting into `RegExp` constructors, guarding against any future
special-character IDs slipping through

```mcfunction
# All of these now work without errors:
scoreboard players reset * test
scoreboard players reset "*" test
```

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: DaanV2 <2393905+DaanV2@users.noreply.github.com>

Author: Copilot

ide/base/server/src/lsp/code-lens/on-request.ts

@@ -69,11 +69,15 @@ function isJson(doc: TextDocument) {
 }
 
 function defaultRegex(id: string) {
-  return new RegExp(`\\b${id}\\b`, 'g');
+  return new RegExp(`\\b${escapeRegex(id)}\\b`, 'g');
 }
 
 function selectorThing(id: string, doc: TextDocument) {
-  return isJson(doc) ? new RegExp(`\\b(${id}=|=${id})\\b`, 'g') : defaultRegex(id);
+  return isJson(doc) ? new RegExp(`\\b(${escapeRegex(id)}=|=${escapeRegex(id)})\\b`, 'g') : defaultRegex(id);
+}
+
+function escapeRegex(id: string): string {
+  return id.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
 }
 
 function config(pd: ProjectData) {

packages/bedrock-diagnoser/src/diagnostics/behavior-pack/mcfunction/commands.ts

@@ -329,7 +329,7 @@ function mcfunction_diagnoseparameter(
   if (pattern.options) {
     //If wildcard is allowed and the text is an wildcard, then skip diagnose
     if (pattern.options.wildcard === true) {
-      if (data.text === '*') return;
+      if (data.text === '*' || data.text === '"*"') return;
     }
 
     //If accepted values is filled in and the text is a match, then skip diagnose

packages/bedrock-project/src/project/general/types/commands/commands.test.ts

@@ -159,4 +159,22 @@ scoreboard players set global id 0`,
     expect(P.general.objectives.count()).toEqual(1);
     expect(P.general.objectives.has('score')).toBeTruthy();
   });
+
+  it('scoreboard wildcard star should not register as fake entity', () => {
+    const P = new ProjectData(new TextProjectContext());
+
+    P.behaviorPacks.add('c:\\bp', MCProject.createEmpty(), {} as Manifest);
+
+    const doc: TextDocument = {
+      uri: 'c:\\bp\\functions\\example.mcfunction',
+      getText: () => `scoreboard players reset * test
+scoreboard players reset "*" test`,
+    };
+
+    P.process(doc);
+
+    // Neither bare * nor quoted "*" should be registered as a fake entity
+    expect(P.general.fakeEntities.count()).toEqual(0);
+    expect(P.general.fakeEntities.has('*')).toBeFalsy();
+  });
 });

packages/bedrock-project/src/project/general/types/objective/process.ts

@@ -1,6 +1,7 @@
 import { Command } from 'bc-minecraft-bedrock-command';
 import { Location } from 'bc-minecraft-bedrock-shared';
 import { Documentation, TextDocument } from '../../../../types';
+import { Text } from '../../../../types';
 import { GeneralCollection } from '../../general';
 import { GeneralInfo } from '../general-info';
 
@@ -68,7 +69,7 @@ function CheckPlayer(Com: Command, doc: TextDocument): GeneralInfo | undefined {
   if (Com.parameters.length > 3) {
     const Selector = Com.parameters[3];
 
-    if (!Selector.text.startsWith('@') && Selector.text !== '*') {
+    if (!Selector.text.startsWith('@') && Text.UnQuote(Selector.text) !== '*') {
       return GeneralInfo.create(
         Selector.text,
         Location.create(doc.uri, Selector.offset),

packages/bedrock-types/src/minecraft/selector/selector.test.ts

@@ -30,12 +30,14 @@ describe('Selector', () => {
       ['"Fake player"', false, true],
       ['@initiator', true, true],
       ['*', true, true],
+      ['"*"', true, true],
     ];
     const invalid: Parameters<typeof Selector.isSelector>[] = [
       ['@x', true, true],
       ['test', false, false],
       ['"Fake player"', false, false],
       ['*', false, false],
+      ['"*"', false, false],
     ];
 
     valid.forEach((args) => {

packages/bedrock-types/src/minecraft/selector/selector.ts

@@ -58,7 +58,7 @@ export namespace Selector {
    */
   export function isSelector(value: string, wildcard?: boolean, allowFakePlayer?: boolean): boolean {
     if (wildcard === true) {
-      if (value === '*') return true;
+      if (value === '*' || value === '"*"') return true;
     }
 
     if (!value.startsWith('@')) {