fix: support quoted structure names in structure command diagnostics#456
Draft
fix: support quoted structure names in structure command diagnostics#456
Conversation
Agent-Logs-Url: https://github.com/Blockception/minecraft-bedrock-language-server/sessions/d83c165a-c17e-48fd-9139-c626a1ae1305 Co-authored-by: DaanV2 <2393905+DaanV2@users.noreply.github.com>
…tion Agent-Logs-Url: https://github.com/Blockception/minecraft-bedrock-language-server/sessions/d83c165a-c17e-48fd-9139-c626a1ae1305 Co-authored-by: DaanV2 <2393905+DaanV2@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
DaanV2
April 23, 2026 06:21
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quoted structure names in commands (e.g.
structure load "mystructure:house" ~ ~ ~) triggered false "missing structure" errors because the diagnoser compared the raw token—including surrounding quotes—against stored unquoted IDs.Changes
diagnose_structure_implementation— callText.UnQuote()on the resolved ID string before all lookup checks, consistent with how other diagnosers (tickingarea, fake-entity, mcfunction, etc.) handle quoted tokens.