Skip to content

fix: support quoted structure names in structure command diagnostics #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanV2 merged 2 commits into from
Apr 24, 2026
Merged

fix: support quoted structure names in structure command diagnostics #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c447c8
chore: outline plan for quote support in structure command diagnose
Copilot Apr 22, 2026
ca7c9d8
fix: strip quotes from structure IDs in diagnose_structure_implementa…
Copilot Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ide/vscode/src/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const Version = "9.0.31";
export const Version = "9.0.32";
3 changes: 2 additions & 1 deletion packages/bedrock-diagnoser/src/diagnostics/behavior-pack/structure/diagnose.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { OffsetWord } from 'bc-minecraft-bedrock-shared';
import { Text } from 'bc-minecraft-bedrock-project';
import { Errors } from '../..';
import { DiagnosticsBuilder } from '../../../types';
import { check_definition_value } from '../../definitions';
Expand All @@ -7,7 +8,7 @@ export function diagnose_structure_implementation(
id: OffsetWord | string,
diagnoser: DiagnosticsBuilder,
): boolean {
const strId = typeof id === 'string' ? id : id.text;
const strId = Text.UnQuote(typeof id === 'string' ? id : id.text);

const data = diagnoser.context.getProjectData().projectData;

Expand Down
12 changes: 12 additions & 0 deletions packages/bedrock-diagnoser/test/lib/diagnostics/behavior-pack/structure.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,18 @@ describe("BehaviorPack", () => {
diagnoser.expectEmpty();
});

it("quoted structure name is looked up unquoted", () => {
data.behaviorPacks.packs[0].structures.set({
id: "mystructure:house",
documentation: "",
location: { position: 0, uri: "" },
});

diagnose_structure_implementation({ offset: 0, text: '"mystructure:house"' }, diagnoser);

diagnoser.expectEmpty();
});

it("missing structure reports error", () => {
diagnose_structure_implementation({ offset: 0, text: "puff:coin1" }, diagnoser);

Expand Down