Skip to content

Commit 1f46304

Browse files
committed
Remove the bitcoind_28_0 feature, assume a newer Bitcoin Core
This no longer seems necessary - v28 was released 15 months ago, the Esplora docker setup uses v30, and the tests were updated to use v29 (in the parent commit).
1 parent c96e1b1 commit 1f46304

3 files changed

Lines changed: 1 addition & 18 deletions

File tree

.github/workflows/rust.yml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -29,22 +29,6 @@ jobs:
2929
- name: Run tests (Bitcoin mode, REST+Electrum)
3030
run: RUST_LOG=debug cargo test
3131

32-
test-bitcoin-28:
33-
runs-on: ubuntu-22.04
34-
steps:
35-
- run: sudo apt-get update && sudo apt-get install libfuse2
36-
- uses: actions/checkout@v4
37-
- uses: dtolnay/rust-toolchain@1.75.0
38-
- uses: Swatinem/rust-cache@v2
39-
- name: Download bitcoind 28.0
40-
run: |
41-
curl -sSL https://bitcoincore.org/bin/bitcoin-core-28.0/bitcoin-28.0-x86_64-linux-gnu.tar.gz | tar -xz
42-
chmod +x bitcoin-28.0/bin/bitcoind
43-
- name: Run tests (Bitcoin 28.0, REST+Electrum)
44-
run: RUST_LOG=debug cargo test --features bitcoind_28_0
45-
env:
46-
BITCOIND_EXE: ${{ github.workspace }}/bitcoin-28.0/bin/bitcoind
47-
4832
test-electrum-raw:
4933
runs-on: ubuntu-22.04
5034
steps:

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ otlp-tracing = [
2626
"opentelemetry-semantic-conventions",
2727
"electrs_macros/otlp-tracing"
2828
]
29-
bitcoind_28_0 = []
3029

3130
[dependencies]
3231
arraydeque = "0.5.1"

tests/rest.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1040,7 +1040,7 @@ fn test_rest_reorg() -> Result<()> {
10401040
}
10411041

10421042
// bitcoin 28.0 only tests - submitpackage
1043-
#[cfg(all(not(feature = "liquid"), feature = "bitcoind_28_0"))]
1043+
#[cfg(not(feature = "liquid"))]
10441044
#[test]
10451045
fn test_rest_submit_package() -> Result<()> {
10461046
let (rest_handle, rest_addr, mut tester) = common::init_rest_tester().unwrap();

0 commit comments

Comments
 (0)