Added db metric reporting and config options.#164
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds database metric reporting capabilities and configuration options for RocksDB performance tuning. The changes enable monitoring of RocksDB internals through Prometheus metrics and provide configurable parameters for memory usage and parallelism.
- Added comprehensive RocksDB metrics collection for memory tables, compactions, and cache usage
- Introduced configuration options for block cache size, parallelism, and write buffer size
- Integrated metrics exporter with background thread to periodically update gauges
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/new_index/db_metrics.rs | New module defining RocksDB metrics structure with comprehensive gauge collections |
| src/new_index/db.rs | Enhanced DB struct with metrics export functionality and configurable RocksDB options |
| src/new_index/schema.rs | Updated Store constructor to accept metrics and initialize DB stats exporters |
| src/new_index/mod.rs | Added db_metrics module export |
| src/config.rs | Added command-line arguments and config fields for RocksDB tuning parameters |
| tests/common.rs | Updated test configuration with new DB parameter defaults |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
291dde2 to
aadd1e3
Compare
Collaborator
Author
|
I amended the commit with copilot's suggestions |
56e68b6 to
9364d54
Compare
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
philippem
reviewed
Sep 16, 2025
9364d54 to
5eb8221
Compare
philippem
reviewed
Sep 17, 2025
5eb8221 to
027e38d
Compare
philippem
approved these changes
Sep 17, 2025
RCasatta
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.