Skip to content

Commit d27d13f

Browse files
authored
Merge pull request #154 from KyrylR/fix/ci
Typescript CI clean up + GitHub templates
2 parents 9c72ebe + fbc4d51 commit d27d13f

5 files changed

Lines changed: 106 additions & 20 deletions

File tree

.github/CODEOWNERS

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# These owners will be requested for review when someone opens a pull request.
2+
* @imaginator
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
name: Bug Report
2+
description: File a bug report
3+
labels: ['bug']
4+
assignees:
5+
- imaginator
6+
body:
7+
- type: markdown
8+
attributes:
9+
value: Thanks for taking the time to fill out this bug report!
10+
- type: input
11+
id: version
12+
attributes:
13+
label: "Project version"
14+
placeholder: "1.2.3"
15+
validations:
16+
required: true
17+
- type: input
18+
id: project
19+
attributes:
20+
label: "Project"
21+
description: "Which subproject or area"
22+
placeholder: "core | compiler | vscode | book | tests | other"
23+
validations:
24+
required: true
25+
- type: textarea
26+
id: what-happened
27+
attributes:
28+
label: What happened?
29+
description: A brief description of what happened and what you expected to happen
30+
validations:
31+
required: true
32+
- type: textarea
33+
id: reproduction-steps
34+
attributes:
35+
label: "Minimal reproduction steps"
36+
description: "The minimal steps needed to reproduce the bug"
37+
validations:
38+
required: true
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
name: Feature request
2+
description: Suggest a new feature
3+
labels: ['feature']
4+
assignees:
5+
- imaginator
6+
body:
7+
- type: input
8+
id: project
9+
attributes:
10+
label: "Project"
11+
description: "Which subproject or area"
12+
placeholder: "core | compiler | vscode | book | tests | other"
13+
validations:
14+
required: true
15+
- type: textarea
16+
id: feature-description
17+
attributes:
18+
label: "Describe the feature"
19+
description: "A description of what you would like to see in the project"
20+
validations:
21+
required: true
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
name: Other issue
3+
about: Other kind of issue
4+
---

.github/workflows/typescript.yml

Lines changed: 41 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,36 +1,57 @@
1-
name: Continious integration for VSCode extension
1+
name: VS Code extension (ESLint)
2+
23
on:
34
push:
45
branches:
56
- master
7+
paths:
8+
- 'vscode/**'
9+
- '.github/workflows/typescript.yml'
10+
pull_request:
11+
branches:
12+
- master
13+
paths:
14+
- 'vscode/**'
15+
- '.github/workflows/typescript.yml'
16+
workflow_dispatch:
17+
618
jobs:
719
eslint:
8-
name: 'Node.js v${{ matrix.node }}'
20+
name: Lint on Node v${{ matrix.node }}
921
runs-on: ubuntu-latest
22+
timeout-minutes: 10
23+
24+
permissions:
25+
contents: read
26+
concurrency:
27+
group: ${{ github.workflow }}-${{ github.ref }}
28+
cancel-in-progress: true
29+
1030
strategy:
31+
fail-fast: false
1132
matrix:
1233
node:
1334
- 22
14-
35+
36+
defaults:
37+
run:
38+
working-directory: ./vscode
39+
1540
steps:
16-
- uses: actions/setup-node@v3
17-
with:
18-
node-version: '${{ matrix.node }}'
19-
2041
- uses: actions/checkout@v4
21-
22-
- name: 'Cache node_modules'
23-
uses: actions/cache@v4
42+
43+
- uses: actions/setup-node@v4
2444
with:
25-
path: ~/.npm
26-
key: ${{ runner.os }}-node-v${{ matrix.node }}-${{ hashFiles('**/package.json') }}
27-
restore-keys: |
28-
${{ runner.os }}-node-v${{ matrix.node }}-
29-
30-
- name: 'Install Dependencies'
45+
node-version: ${{ matrix.node }}
46+
cache: 'npm'
47+
cache-dependency-path: vscode/package-lock.json
48+
49+
- name: Install dependencies
3150
run: npm ci
32-
working-directory: ./vscode
33-
34-
- name: 'Run ESLint'
51+
env:
52+
CI: true
53+
54+
- name: Run ESLint
3555
run: npm run eslint-check
36-
working-directory: ./vscode
56+
env:
57+
CI: true

0 commit comments

Comments
 (0)