Merge #59: Verification for option creation contract

dff4460 Add a verification that `tx` is a well-formed new issuance tx (Kyryl R)

Pull request description:

  This PR is solving the verification for the #36
  Solution described in #36 (comment)

Top commit has no ACKs.

Tree-SHA512: e028346121c96862111f98f77718ccc9143f0d7f29a9d73f50ae4ef313857d5088aa5100f396cd6aef5aaf7deca0f183fa96076b5156a274af740bb189989062

Author: KyrylR

crates/contracts/src/array_tr_storage/build_witness.rs

@@ -17,7 +17,7 @@ pub struct State {
 
 impl State {
     #[must_use]
-    pub fn new() -> Self {
+    pub const fn new() -> Self {
         Self {
             limbs: [[0u8; 32]; MAX_VAL],
         }

crates/contracts/src/array_tr_storage/mod.rs

@@ -161,7 +161,7 @@ mod array_tr_storage_tests {
         let outpoint0 = OutPoint::new(Txid::from_slice(&[0; 32])?, 0);
         pst.add_input(Input::from_prevout(outpoint0));
         pst.add_output(Output::new_explicit(
-            new_script_pubkey.clone(),
+            new_script_pubkey,
             0,
             AssetId::default(),
             None,

crates/contracts/src/error.rs

@@ -123,6 +123,9 @@ pub enum TransactionBuildError {
 
     #[error(transparent)]
     TaprootPubkeyGen(#[from] TaprootPubkeyGenError),
+
+    #[error(transparent)]
+    IssuanceValidation(#[from] crate::sdk::IssuanceVerificationError),
 }
 
 /// Errors from extracting arguments from Arguments struct.

crates/contracts/src/sdk/finance/options/creation_option.rs

@@ -5,6 +5,7 @@ use crate::error::TransactionBuildError;
 
 use crate::sdk::taproot_pubkey_gen::TaprootPubkeyGen;
 use crate::sdk::validation::TxOutExt;
+use crate::sdk::{IssuanceInputConstraints, IssuanceTxConstraints, verify_issuance};
 
 use std::collections::HashMap;
 
@@ -154,6 +155,31 @@ pub fn build_option_creation(
     inp_txout_sec.insert(0, first_input_secrets);
     inp_txout_sec.insert(1, second_input_secrets);
 
+    verify_issuance(
+        &pst.extract_tx()?,
+        &IssuanceTxConstraints {
+            inputs: vec![
+                IssuanceInputConstraints {
+                    input_idx: 0,
+                    issuance_destination: None,
+                    reissuance_destination: Some((
+                        options_taproot_pubkey_gen.address.script_pubkey(),
+                        1,
+                    )),
+                },
+                IssuanceInputConstraints {
+                    input_idx: 1,
+                    issuance_destination: None,
+                    reissuance_destination: Some((
+                        options_taproot_pubkey_gen.address.script_pubkey(),
+                        1,
+                    )),
+                },
+            ],
+            allow_unconstrained_issuances: false,
+        },
+    )?;
+
     pst.blind_last(&mut thread_rng(), secp256k1::SECP256K1, &inp_txout_sec)?;
 
     pst.extract_tx()?