Static asserts on imr_buf not needed

roconnor-blockstream · roconnor-blockstream · commit 274d8f2e56e6 · 2024-12-18T15:49:50.000-05:00
Since ed507e6 the imr_buf argument to verifyNoDuplicateIdentityRoots is no longer an array. Therefore the static checks are no longer needed.
diff --git a/C/primitive/elements/exec.c b/C/primitive/elements/exec.c
@@ -97,9 +97,6 @@ extern bool simplicity_elements_execSimplicity( simplicity_err* error, unsigned
     }
     if (IS_OK(*error)) {
       sha256_midstate imr_buf;
-      static_assert(DAG_LEN_MAX <= SIZE_MAX / sizeof(sha256_midstate), "imr_buf array too large.");
-      static_assert(1 <= DAG_LEN_MAX, "DAG_LEN_MAX is zero.");
-      static_assert(DAG_LEN_MAX - 1 <= UINT32_MAX, "imr_buf array index does nto fit in uint32_t.");
       *error = simplicity_verifyNoDuplicateIdentityRoots(&imr_buf, dag, type_dag, (uint_fast32_t)dag_len);
       if (IS_OK(*error) && imr) sha256_fromMidstate(imr, imr_buf.s);
     }

Original file line number	Diff line number	Diff line change
`@@ -97,9 +97,6 @@ extern bool simplicity_elements_execSimplicity( simplicity_err* error, unsigned`
`97`	`97`	`}`
`98`	`98`	`if (IS_OK(*error)) {`
`99`	`99`	`sha256_midstate imr_buf;`
`100`		`- static_assert(DAG_LEN_MAX <= SIZE_MAX / sizeof(sha256_midstate), "imr_buf array too large.");`
`101`		`- static_assert(1 <= DAG_LEN_MAX, "DAG_LEN_MAX is zero.");`
`102`		`- static_assert(DAG_LEN_MAX - 1 <= UINT32_MAX, "imr_buf array index does nto fit in uint32_t.");`
`103`	`100`	`*error = simplicity_verifyNoDuplicateIdentityRoots(&imr_buf, dag, type_dag, (uint_fast32_t)dag_len);`
`104`	`101`	`if (IS_OK(*error) && imr) sha256_fromMidstate(imr, imr_buf.s);`
`105`	`102`	`}`