Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

Commit 08784e0

Browse files
authored
Removed command setLambdaDeadLetterConfig. (gmetzker#31)
Updated documentation with required versions. Updated version number and change log
1 parent b9ffa5a commit 08784e0

4 files changed

Lines changed: 20 additions & 15 deletions

File tree

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,12 @@
1+
# 1.2.1 (2017-01-31)
2+
3+
## Bug Fixes
4+
* Removed the plugin command `setLambdaDeadLetterConfig` because it didn't work in all scenarios.
5+
6+
## Meta
7+
* [Comparison since last release](https://github.com/gmetzker/serverless-plugin-lambda-dead-letter/compare/v1.2.0...v1.2.1)
8+
9+
110
# 1.2.0 (2017-01-30)
211

312
## Features

README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,15 @@ At the time this plugin was developed AWS Cloudformation (and serverless) did no
2121

2222
## Installation
2323

24+
### Requirements
25+
* nodeJs > `v4.0`
26+
* serverless > `v1.4`
27+
28+
Install the plugin.
29+
```bash
30+
npm install serverless-plugin-lambda-dead-letter
31+
```
32+
2433
Install the plugin with npm and reference it in the serverless yaml file [as documented here.](https://serverless.com/framework/docs/providers/aws/guide/plugins/)
2534

2635
```YAML

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "serverless-plugin-lambda-dead-letter",
3-
"version": "1.2.0",
3+
"version": "1.2.1",
44
"description": "serverless plugin that can configure a lambda with a dead letter queue or topic",
55
"main": "src/index.js",
66
"scripts": {

src/index.js

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,9 @@ class Plugin {
1717
.then(this.setLambdaDeadLetterConfig),
1818

1919
'deploy:compileEvents': () => BbPromise.bind(this)
20-
.then(this.compileFunctionDeadLetterResources),
21-
22-
23-
'setLambdaDeadLetterConfig:setLambdaDeadLetterConfig': () => BbPromise.bind(this)
24-
.then(this.setLambdaDeadLetterConfig)
20+
.then(this.compileFunctionDeadLetterResources)
2521

2622
};
27-
28-
this.commands = {
29-
setLambdaDeadLetterConfig: {
30-
usage: 'Adds subscriptions to any SNS Topics defined by externalSNS.',
31-
lifecycleEvents: ['setLambdaDeadLetterConfig']
32-
}
33-
};
34-
35-
3623
}
3724

3825
resolveTargetArn(functionName, deadLetter, resolveStackResources) {

0 commit comments

Comments
 (0)