Control the font used for book buttons in RAB books (BL-16351)#7977
Conversation
|
| Filename | Overview |
|---|---|
| src/BloomBrowserUI/bookEdit/js/linkGrid.ts | Adds lang attribute to bloom-link-grid elements using the collection's language1 tag, enabling CSS font rules to target the correct language; change is small, focused, and logically correct. |
Reviews (3): Last reviewed commit: "Control the font used for book buttons i..." | Re-trigger Greptile
hatton
left a comment
There was a problem hiding this comment.
@hatton made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on StephenMcConnel).
src/content/bookLayout/basePage-sharedRules.less line 293 at r1 (raw file):
.bloom-canvas .bloom-canvas-element .bloom-link-grid .bloom-bookButton p { font-size: var(--DefaultBookButtonFontSize, 10pt); font-family: Andika, NotoSans, sans-serif;
What if their language needs a different font? It doesn't seem like any fixed list will do here.
ef108ef to
a715142
Compare
StephenMcConnel
left a comment
There was a problem hiding this comment.
@StephenMcConnel made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on hatton).
src/content/bookLayout/basePage-sharedRules.less line 293 at r1 (raw file):
Previously, hatton (John Hatton) wrote…
What if their language needs a different font? It doesn't seem like any fixed list will do here.
I changed the code to inject the Language1 font on the paragraph elements.
and in the edit tab and bloompub preview as well.
a715142 to
5d9bcb0
Compare
StephenMcConnel
left a comment
There was a problem hiding this comment.
@StephenMcConnel made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on hatton and StephenMcConnel).
src/content/bookLayout/basePage-sharedRules.less line 293 at r1 (raw file):
Previously, StephenMcConnel (Steve McConnel) wrote…
I changed the code to inject the Language1 font on the paragraph elements.
The code has changed again to just set the lang attribute on the .bloom-link-grid elements.
StephenMcConnel
left a comment
There was a problem hiding this comment.
final change I hope
@StephenMcConnel made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on hatton and StephenMcConnel).
hatton
left a comment
There was a problem hiding this comment.
@hatton partially reviewed 2 files.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on StephenMcConnel).
Devin review
This change is