refactor(plugins/anthropic): migrate plugin to v2 API#347
Merged
Conversation
CorieW
marked this pull request as draft
September 22, 2025 21:53
xavidop
marked this pull request as ready for review
September 23, 2025 15:58
7 tasks
Contributor
|
@CorieW build is failing on anthropic example, probably needs a bit of investigation |
cabljac
reviewed
Oct 14, 2025
cabljac
left a comment
cabljac
left a comment
Contributor
There was a problem hiding this comment.
couple of comments so far
cabljac
reviewed
Oct 14, 2025
Contributor
|
I think the list method might need to call the anthropic SDK list models method/ API endpoint, and return "potential" models etc. We should double check this. This seems to be what google-genai is doing. |
CorieW
force-pushed
the
migrate-anthropic-v2
branch
from
October 20, 2025 16:43
cad60e9 to
8ea4446
Compare
CorieW
force-pushed
the
migrate-anthropic-v2
branch
from
October 20, 2025 16:44
8ea4446 to
df8c45a
Compare
cabljac
reviewed
Oct 23, 2025
| configSchema: ref.configSchema, | ||
| }) : undefined; | ||
| }) | ||
| // Filter out undefined values |
Contributor
There was a problem hiding this comment.
is comment necessary? would rather have a comment explaining why this logic works/is necessary
Contributor
There was a problem hiding this comment.
or no comment maybe, clear from code above
xavidop
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #349
What this does
Testing
'pluginName/modelName'), checked using a flow works consistent with pre-migration..list