fix: segments contacts endpoint, empty API response handling, completion newline

- segments contacts: use alias-based search instead of non-existent
  /segments/{id}/contacts endpoint
- client: handle empty response bodies and non-JSON responses gracefully
  instead of crashing with JSONDecodeError (Mautic returns empty body
  on 401 with application/json content-type)
- completion: add newline before eval in shell rc append to prevent
  concatenation with previous line

Author: introfini

src/mautic_cli/cli.py

@@ -167,7 +167,7 @@ def completion(shell):
         if shell == "fish":
             con.print(f"  mautic completion fish > {rc_file}\n")
         else:
-            con.print(f'  echo \'eval "$(mautic completion {shell})"\' >> {rc_file}')
+            con.print(f"  echo '\\neval \"$(mautic completion {shell})\"' >> {rc_file}")
             con.print(f"  source {rc_file}\n")
     else:
         click.echo(result.stdout, nl=False)

src/mautic_cli/client.py

@@ -182,7 +182,21 @@ def _request(self, method: str, path: str, **kwargs) -> dict:
             if self.verbose:
                 print(f"<< {response.status_code} (after token refresh)", file=sys.stderr)
 
-        data = response.json()
+        if not response.content:
+            content_type = response.headers.get("content-type", "")
+            raise MauticApiError(
+                message=f"Empty response body (HTTP {response.status_code}). Content-Type: {content_type}",
+                code=response.status_code,
+                error_type="empty_response",
+            )
+        try:
+            data = response.json()
+        except Exception:
+            raise MauticApiError(
+                message=f"Response is not valid JSON (HTTP {response.status_code})",
+                code=response.status_code,
+                error_type="invalid_response",
+            )
         if response.status_code >= 400:
             self._raise_api_error(data, response.status_code)
         return data

src/mautic_cli/commands/segments.py

@@ -52,8 +52,18 @@ def get(mctx: MauticContext, id):
 def contacts(mctx: MauticContext, id, limit):
     """List contacts in a segment."""
     try:
-        data = mctx.client.get(f"/segments/{id}/contacts", params={"limit": limit})
-        mctx.output(data)
+        # Fetch segment to get its alias for search
+        segment_data = mctx.client.get(f"/segments/{id}")
+        segment = segment_data.get("list", {})
+        alias = segment.get("alias", "")
+        if not alias:
+            mctx.output({"total": 0, "contacts": {}})
+            return
+        data = mctx.client.get("/contacts", params={
+            "search": f"segment:{alias}",
+            "limit": limit,
+        })
+        mctx.output_list(data, "contacts")
     except MauticApiError as e:
         mctx.error(e)
         raise SystemExit(1)

tests/test_segments.py

@@ -52,7 +52,14 @@ def test_create_segment(self):
 
     @respx.mock
     def test_segment_contacts(self):
-        respx.get("https://mautic.test/api/segments/1/contacts").mock(
+        # First call: fetch segment to get alias
+        respx.get("https://mautic.test/api/segments/1").mock(
+            return_value=httpx.Response(200, json={
+                "list": {"id": 1, "name": "Newsletter", "alias": "newsletter"},
+            })
+        )
+        # Second call: search contacts by segment alias
+        respx.get("https://mautic.test/api/contacts").mock(
             return_value=httpx.Response(200, json={
                 "total": "1",
                 "contacts": {"42": {"id": 42}},