EDF 4.1: Improved reflections patch#17
Open
metoxys wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDF 4.1's reflections are completely and utterly awful. This changes the situation a lot.
Vanilla reflections have no fresnel, no angular falloff, and worst of all, 1024x1024 environment maps without LODs (I kid you not, even EDF 2025 on the Xbox 360, with its 256x256 envmaps, had the decency to have 8 mipmaps)
This patch augments a compute shader (first reverse-engineered from disasm and then A/B tested to achieve pixel parity) by adding a 25-tap angle-dependent cubic blur with quadratic weighing. Head-on reflections remain sharp (but not "I can make out every individual pixel" sharp) while grazing angles now get strong, colored, and natural-looking environment reflections
(no anti-aliasing was used in this before/after)

