Correct comment and add missing bounds check for OPTCopyLoad

BlueAmulet · BlueAmulet · commit db7197f4b431 · 2024-09-15T14:03:30.000-06:00
diff --git a/Packages/blueamulet.udonsharpoptimizer/Editor/Optimizations/OPTCopyLoad.cs b/Packages/blueamulet.udonsharpoptimizer/Editor/Optimizations/OPTCopyLoad.cs
@@ -13,8 +13,8 @@ public bool Enabled()
 
         public void ProcessInstruction(Optimizer optimizer, List<AssemblyInstruction> instrs, int i)
         {
-            // Remove Copy: Copy + JumpIf
-            if (instrs[i] is CopyInstruction cInst && instrs[i + 1] is PushInstruction pInst)
+            // Remove Copy: Copy + Push
+            if (instrs[i] is CopyInstruction cInst && i < instrs.Count - 1 && instrs[i + 1] is PushInstruction pInst)
             {
                 if (Optimizer.IsPrivate(cInst.TargetValue) && cInst.TargetValue.UniqueID == pInst.PushValue.UniqueID && !optimizer.HasJump(pInst) && !optimizer.ReadScan(n => n == i + 1, cInst.TargetValue))
                 {

Original file line number	Diff line number	Diff line change
`@@ -13,8 +13,8 @@ public bool Enabled()`
`13`	`13`
`14`	`14`	`public void ProcessInstruction(Optimizer optimizer, List<AssemblyInstruction> instrs, int i)`
`15`	`15`	`{`
`16`		`- // Remove Copy: Copy + JumpIf`
`17`		`- if (instrs[i] is CopyInstruction cInst && instrs[i + 1] is PushInstruction pInst)`
	`16`	`+ // Remove Copy: Copy + Push`
	`17`	`+ if (instrs[i] is CopyInstruction cInst && i < instrs.Count - 1 && instrs[i + 1] is PushInstruction pInst)`
`18`	`18`	`{`
`19`	`19`	`if (Optimizer.IsPrivate(cInst.TargetValue) && cInst.TargetValue.UniqueID == pInst.PushValue.UniqueID && !optimizer.HasJump(pInst) && !optimizer.ReadScan(n => n == i + 1, cInst.TargetValue))`
`20`	`20`	`{`