Skip to content

Feature/lidar_proto#191

Open
jonpg01 wants to merge 4 commits into
feature/ros2_slam_nav_intfrom
feature/lidar_proto
Open

Feature/lidar_proto#191
jonpg01 wants to merge 4 commits into
feature/ros2_slam_nav_intfrom
feature/lidar_proto

Conversation

@jonpg01

@jonpg01 jonpg01 commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@jonpg01 jonpg01 requested a review from stefanvogel June 22, 2026 07:21
Comment thread webots/protos/ZumoComSystem.proto Outdated
field SFString name "ZumoComSystem"
field SFBool performanceMode FALSE # Use basic blocks for the robot instead of meshes. Increases performance.
field SFBool synchronization TRUE # Set to FALSE when used alongside another extern controller.
field SFNode flagshipSlot NULL # Slot for the FlagShip

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
field SFNode flagshipSlot NULL # Slot for the FlagShip
field SFNode flagShipSlot NULL # Slot for the FlagShip

Comment thread webots/protos/ZumoComSystem.proto Outdated
}
Slot {
type "FlagShip"
endPoint IS flagshipSlot

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endPoint IS flagshipSlot
endPoint IS flagShipSlot

Comment on lines +7 to +24
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/plants/protos/PottedTree.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/floors/protos/Floor.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/appearances/protos/CementTiles.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/apartment_structure/protos/Window.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/apartment_structure/protos/Wall.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/appearances/protos/Roughcast.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/apartment_structure/protos/Radiator.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/apartment_structure/protos/Door.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/cabinet/protos/Cabinet.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/factory/containers/protos/CardboardBox.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/kitchen/fridge/protos/Fridge.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/lights/protos/FloorLight.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/living_room_furniture/protos/Sofa.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/living_room_furniture/protos/Armchair.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/paintings/protos/LandscapePainting.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/tables/protos/Table.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/traffic/protos/DirectionPanel.proto"
EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/develop/projects/objects/plants/protos/BunchOfSunFlowers.proto"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you pin to a specific version here instead of using the develop branch (which is a moving target)?

@@ -0,0 +1,68 @@
#VRML_SIM R2023b utf8

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be R2025a as well I guess.

Comment on lines +1 to +3
#VRML_SIM R2023a utf8

EXTERNPROTO "https://raw.githubusercontent.com/cyberbotics/webots/R2023a/projects/objects/floors/protos/RectangleArena.proto"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to R2025a?

@@ -0,0 +1,237 @@
#VRML_SIM R2023b utf8

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to R2025a?

Comment thread webots/protos/FlagShip.proto
@jonpg01 jonpg01 requested a review from stefanvogel June 26, 2026 12:15

@stefanvogel stefanvogel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving

@@ -0,0 +1,47 @@
#VRML_SIM R2025a utf8

# FlagShip is a extension that is mounted on top of the ZumoComSystem (DroidControlShip).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# FlagShip is a extension that is mounted on top of the ZumoComSystem (DroidControlShip).
# FlagShip is an extension that is mounted on top of the ZumoComSystem (DroidControlShip).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants