[Fix] test_changed_lines_policy の対象スコープを design/ に narrow#173
Merged
BlueEventHorizon merged 1 commit intoJul 6, 2026
Merged
Conversation
…外の design/ narrow に変更 Closes #169
BlueEventHorizon
marked this pull request as ready for review
July 6, 2026 11:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
test_changed_lines_do_not_add_standalone_subagentの対象パス (CHECKED_PATH_PREFIXES) が要件定義書まで含んでおり、実装経路を指図しない一般用語 (subagent) の使用で誤検知していた問題を修正背景
forge-session-dss 計画書の AI レビュー実行中に、
docs/specs/forge/requirements/REQ-007_dss_v2.md:47の「subagent (子)」でtest_changed_lines_do_not_add_standalone_subagentが失敗することを発見した (Issue #169)。docs/rules/skill_launch_paths_definitions.md§2 の用語統一ルールは対象を明示的に「SKILL.md / 設計書 / ガイド文書」と限定しており要件定義書は含まれない。これはdocs/readme/guide_sdd_ja.mdの What/How 境界(要件定義書=What・技術中立、設計書=How・技術依存)とも整合する。docs/specs/forge/design/配下は既にsubagent単独使用が 0 件であり、要件定義書側のみが誤検知源だった。やったこと
tests/forge/subagent/test_changed_lines_policy.pyのCHECKED_PATH_PREFIXESをdocs/specs/forge/からdocs/specs/forge/design/に narrow し、要件定義書を検査対象から除外やらないこと(このプルリクエストのスコープ外とすること)
CHECKED_PATH_PREFIXESの対象外)REQ-007_dss_v2.md:47自体の文言修正(要件定義書は用語統一の対象外という結論のため不要)レビュー観点
CHECKED_PATH_PREFIXESを narrow したことで design/ 配下の既存検査が意図せず弱まっていないか/forge:review code(evaluator) は本変更をfalse_positiveの reviewer 指摘(DES-030 は本変更のスコープを管轄しない設計書)として却下済みレビューレベル
Lv0: まったく見ないでAcceptするLv1: ぱっとみて違和感がないかチェックしてAcceptするLv3: 実際に環境で動作確認したうえでAcceptする備考
Closes #169