[Fix] reviewer.md の engine=codex 時の二重レビュー構造を修正#217
Merged
BlueEventHorizon merged 1 commit intoJul 17, 2026
Conversation
reviewer.md の Phase 2/3 (P1→P2→P3 自前評価・severity 委譲) が engine 条件なしの 直列記述になっており、engine=codex 時にも実行され得ることで codex 実行との二重 レビューを招く不具合を修正。Phase 2/3 を engine=claude (Codex 不在時のフォール バック含む) 限定と明記し、Phase 1 の Read 範囲も engine=codex 時は最小限に留める よう修正。Codex 不在フォールバック時に実効 engine を claude に切り替えて Phase 1 未読分 + Phase 2/3 を再開する手順も明記した。 DES-015 §Phase4① および DES-029 §4.2 シーケンス図を、上記の engine 分岐と整合す るよう更新。静的回帰テスト (test_codex_launch_path.py) を追加。 Closes #210
BlueEventHorizon
marked this pull request as ready for review
July 17, 2026 11:08
BlueEventHorizon
deleted the
fix/210-reviewer-engine-branch-double-review
branch
July 17, 2026 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
/forge:review の reviewer 遅延調査で発見された、engine=codex 時にも reviewer Agent 自身が
全参照文書の精読と自前レビュー(P1→P2→P3評価)を実行し得る二重レビュー構造を修正。
背景
plugins/forge/agents/reviewer.md のワークフローが Phase 1(全文書Read)→ Phase 2/3
(レビュー実行)→ Phase 4(エンジン別の実行)の直列構成で、Phase 2/3 に engine=claude
限定の条件が明記されていなかった。
やったこと
engine=claude(Codex不在時のフォールバック含む)限定と明記
dprint fmt言及)も削除やらないこと(このプルリクエストのスコープ外とすること)
レビュー観点
レビューレベル
Lv0: まったく見ないでAcceptするLv1: ぱっとみて違和感がないかチェックしてAcceptするLv3: 実際に環境で動作確認したうえでAcceptするCloses #210