Commit 1d6a567
fix(win): export embedded LibMTRSim symbols from the plugin DLL on MSVC
The plugin-build shim hard-coded LIBMTRSIM_EXPORT to empty. On Unix that is
fine (default visibility exports the symbols), but on MSVC nothing is exported
from the plugin DLL, so external consumers (MTRSimUnitTest, the Python
bindings) fail to link mtrsim:: free functions (readODFComponents,
readODFMetadata, tryReadFixtureVersion) with LNK2019/LNK1120. Key the macro on
MTRSim_EXPORTS (dllexport when building the plugin, dllimport when consuming),
matching the plugin's own export macro. macOS build + 42/42 tests unaffected.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 1fb3b4e commit 1d6a567
1 file changed
Lines changed: 23 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
6 | 14 | | |
7 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
0 commit comments