BUG: Remove m_UseOoc gate from Preferences::forceOocData getter and setter

The force_ooc_data preference is intended as an independent user toggle
that overrides the "in-memory format" choice — "force every eligible
array to OOC regardless of the selected large-data format." But both the
getter and setter were gated on m_UseOoc, which is only true when the
selected format is something other than the in-memory sentinel.

Effect of the bug: when the user's large-data format was
'Simplnx-Default-In-Memory' (the default), toggling Force OOC in the
Preferences dialog had zero effect. The setter silently dropped the new
value (because the gate returned early), and even if the key had been
persisted in a prior session, the getter would always return false.

The OocDataIOManager format resolver already handles the
(forceOoc=true, userChoseInMemory=true) case correctly — it returns
'HDF5-OOC' for every eligible array. The upstream gate in the
preference class prevented that design from ever being reached.

Removing the gate in both the getter and setter lets the toggle work
as designed: when Force OOC is on, the format resolver routes every
eligible array to OOC storage even if the user's format preference
still says in-memory.

Discovered while debugging a 6-second drag-drop-to-outline latency on
a 25 GB dataset — the user had Force OOC on and the 2 GB large-data
threshold set, but arrays were still being eagerly loaded into RAM.
The root cause was this preference gate silently defeating the user's
choice.

Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>

Author: joeykleingers

src/simplnx/Core/Preferences.cpp

@@ -323,19 +323,22 @@ bool Preferences::useOocData() const
 
 bool Preferences::forceOocData() const
 {
-  if(!m_UseOoc)
-  {
-    return false;
-  }
+  // The force_ooc_data flag is an independent user preference. It must not
+  // be gated on m_UseOoc — the whole point of force_ooc_data is to override
+  // the "in-memory format" choice when the user wants every eligible array
+  // routed to OOC anyway. The OocDataIOManager format resolver explicitly
+  // handles the (forceOoc=true, userChoseInMemory=true) case by returning
+  // "HDF5-OOC". Gating here defeats that design and silently makes the
+  // preference checkbox useless whenever the large-data format is set to
+  // in-memory.
   return valueAs<bool>(k_ForceOocData_Key);
 }
 
 void Preferences::setForceOocData(bool forceOoc)
 {
-  if(!m_UseOoc)
-  {
-    return;
-  }
+  // See forceOocData() — the m_UseOoc gate is intentionally absent so a
+  // user toggling the Force OOC checkbox in the Preferences dialog always
+  // persists, regardless of the currently-selected large-data format.
   setValue(k_ForceOocData_Key, forceOoc);
 }