Add SimplePriorityQueue.Try...() overloads that expose priority as out parameter#55
Open
JohannesMP wants to merge 6 commits into
Open
Add SimplePriorityQueue.Try...() overloads that expose priority as out parameter#55JohannesMP wants to merge 6 commits into
JohannesMP wants to merge 6 commits into
Conversation
…ut the priority of the removed node
| /// Returns true if successful; false if queue was empty | ||
| /// O(log n) | ||
| /// </summary> | ||
| public bool TryDequeue(out TItem first, out TPriority firstPriority) |
There was a problem hiding this comment.
I think this is a duplicate method. Create method, that dequeues simple node (private bool TryDequeue(out SimpleNode node)) and use it in both TryDequeue overrides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimplePriorityQueue.TryDequeue()overload without TPriorityparameter and relevant unit testsSimplePriorityQueue.TryRemove()overload without TPriorityparameter and relevant unit testsSimplePriorityQueue.TryFirst()overload without TPriorityparameter and relevant unit testsIn each case if the caller wants the priority of the head/head-to-be-removed/node-to-be-removed, they can now get it without an additional
(Try)GetPrioritycall, making it easier to remain thread-safe while also avoiding an extra_itemToNodesCachelookup.See issue #54