refactor(gap): rename _uncached_parse_advertisement_data/_tuple to reflect bytes-cache routing

Author: bluetoothbot

bench/test_parse_gap_tuple.py

@@ -2,7 +2,7 @@
     parse_advertisement_data_bytes,
     parse_advertisement_data_tuple,
 )
-from bluetooth_data_tools.gap import _uncached_parse_advertisement_data
+from bluetooth_data_tools.gap import _parse_advertisement_data_miss_via_bytes
 
 #  cythonize -X language_level=3 -a -i  src/bluetooth_data_tools/gap.py
 
@@ -91,7 +91,7 @@ def test_parse_advertisement_data_tuple(benchmark):
 
 def test_parse_advertisement_data_tuple_uncached(benchmark):
     joined_advs = b"".join(advs)
-    benchmark(lambda: _uncached_parse_advertisement_data(joined_advs))
+    benchmark(lambda: _parse_advertisement_data_miss_via_bytes(joined_advs))
 
 
 def test_parse_advertisement_data_tuple_bytes_cache_fallthrough(benchmark):

src/bluetooth_data_tools/gap.pxd

@@ -59,6 +59,6 @@ cpdef parse_advertisement_data(object data)
 )
 cpdef _uncached_parse_advertisement_bytes(bytes gap_bytes)
 
-cpdef _uncached_parse_advertisement_data(bytes data)
+cpdef _parse_advertisement_data_miss_via_bytes(bytes data)
 
-cpdef _uncached_parse_advertisement_tuple(tuple data)
+cpdef _parse_advertisement_tuple_miss_via_bytes(tuple data)

src/bluetooth_data_tools/gap.py

@@ -150,7 +150,7 @@ def _parse_advertisement_data(
     data: bytes,
 ) -> BLEGAPAdvertisement:
     """Parse advertisement data and return a BLEGAPAdvertisement."""
-    return _uncached_parse_advertisement_data(data)
+    return _parse_advertisement_data_miss_via_bytes(data)
 
 
 _cached_parse_advertisement_data = _parse_advertisement_data
@@ -183,17 +183,17 @@ def parse_advertisement_data(
     return _cached_parse_advertisement_data(b"".join(data))
 
 
-def _uncached_parse_advertisement_data(data: bytes) -> BLEGAPAdvertisement:
+def _parse_advertisement_data_miss_via_bytes(data: bytes) -> BLEGAPAdvertisement:
     # Route BLEGAPAdvertisement-cache misses through the bytes-keyed cache
-    # (symmetric with _uncached_parse_advertisement_tuple, see #261). Identical
-    # payloads reaching this miss path skip the full parse when the bytes-tuple
-    # cache already holds the result, and a true miss populates that cache so
-    # subsequent parse_advertisement_data_bytes / parse_advertisement_data_tuple
-    # calls on the same payload also win.
+    # (symmetric with _parse_advertisement_tuple_miss_via_bytes, see #261).
+    # Identical payloads reaching this miss path skip the full parse when the
+    # bytes-tuple cache already holds the result, and a true miss populates
+    # that cache so subsequent parse_advertisement_data_bytes /
+    # parse_advertisement_data_tuple calls on the same payload also win.
     return BLEGAPAdvertisement(*parse_advertisement_data_bytes(data))
 
 
-def _uncached_parse_advertisement_tuple(
+def _parse_advertisement_tuple_miss_via_bytes(
     data: tuple[bytes, ...],
 ) -> BLEGAPAdvertisementTupleType:
     # Route tuple-cache misses through the bytes-keyed cache so identical
@@ -386,11 +386,11 @@ def parse_advertisement_data_tuple(
         manufacturer_data: dict[int, bytes]
         tx_power: int | None
         """
-        return _uncached_parse_advertisement_tuple(data)
+        return _parse_advertisement_tuple_miss_via_bytes(data)
 else:
     parse_advertisement_data_bytes = lru_cache(maxsize=1024)(
         _uncached_parse_advertisement_bytes
     )
     parse_advertisement_data_tuple = lru_cache(maxsize=256)(
-        _uncached_parse_advertisement_tuple
+        _parse_advertisement_tuple_miss_via_bytes
     )

tests/benchmarks/test_parse_gap_tuple.py

@@ -5,7 +5,7 @@
     parse_advertisement_data_bytes,
     parse_advertisement_data_tuple,
 )
-from bluetooth_data_tools.gap import _uncached_parse_advertisement_data
+from bluetooth_data_tools.gap import _parse_advertisement_data_miss_via_bytes
 
 advs = (
     b"\x02\x01\x06\x03\x03\x12\x18\x10\tLOOKin_98F33163\x03\x19\xc1\x03",
@@ -92,7 +92,7 @@ def test_parse_advertisement_data_tuple(benchmark: BenchmarkFixture) -> None:
 
 def test_parse_advertisement_data_tuple_uncached(benchmark: BenchmarkFixture) -> None:
     joined_advs = b"".join(advs)
-    benchmark(lambda: _uncached_parse_advertisement_data(joined_advs))
+    benchmark(lambda: _parse_advertisement_data_miss_via_bytes(joined_advs))
 
 
 def test_parse_advertisement_data_tuple_bytes_cache_fallthrough(

tests/test_gap_fuzzer.py

@@ -15,7 +15,7 @@
 import random
 
 from bluetooth_data_tools.gap import (
-    _uncached_parse_advertisement_data,
+    _parse_advertisement_data_miss_via_bytes,
     parse_advertisement_data,
 )
 
@@ -32,7 +32,7 @@ def test_gap_fuzzer_random_bytes_do_not_crash() -> None:
             bytes(rng.randint(0, 255) for _ in range(rng.randint(1, 31))),
             bytes(rng.randint(0, 255) for _ in range(rng.randint(1, 31))),
         )
-        _uncached_parse_advertisement_data(b"".join(adv))
+        _parse_advertisement_data_miss_via_bytes(b"".join(adv))
 
 
 def test_gap_fuzzer_truncated_length_does_not_crash() -> None: