feat: add parse_advertisement_data_bytes method#121
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
===========================================
- Coverage 100.00% 99.59% -0.41%
===========================================
Files 6 6
Lines 226 245 +19
Branches 27 32 +5
===========================================
+ Hits 226 244 +18
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #121 will degrade performances by 30.48%Comparing Summary
Benchmarks breakdown
|
Member
Author
|
savings potential is 2us....not so worth it |
bluetoothbot
added a commit
to bluetoothbot/bluetooth-data-tools
that referenced
this pull request
May 20, 2026
The pytest-benchmark suite under bench/ — which feeds the CI step summary via --benchmark-autosave — drifted out of sync with the codspeed suite under tests/benchmarks/ when Bluetooth-Devices#237 added native mac_to_int and Bluetooth-Devices#121 added parse_advertisement_data_bytes. Both functions are present in the codspeed runs but missing from the GitHub Actions step-summary comparison, so regressions in those paths don't show up in the human-readable CI report. Mirror the codspeed tests into bench/ using the local style (no BenchmarkFixture import, no type annotations) so the step summary covers both fast paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that this will make
parse_advertisement_dataa bit slower, but nothing uses that anymore in the HA bluetooth stack and its only there for backwards compatibility to avoid a breaking change.I wasn't originally planning to move this PR forward for the 2us performance benefit, but now that we need it to solve home-assistant/core#143769 (comment) it makes sense to do so