perf: inline int.from_bytes in UUID conversion functions#202
Closed
bdraco wants to merge 1 commit into
Closed
Conversation
Replace partial(int.from_bytes) wrapper with direct calls to eliminate ~0.025 us partial call overhead per cache miss.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 255 254 -1
Branches 38 38
=========================================
- Hits 255 254 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
partial(int.from_bytes, byteorder="little")wrapper calls with directint.from_bytes(..., byteorder="little")in_uint128_bytes_as_uuid,_uint16_bytes_as_uuid, and_uint32_bytes_as_uuidfrom_bytes_littledefinition fromgap.pyand its declaration fromgap.pxdpartialcall overhead per LRU cache missTest plan